Stack Overflow in network discovery on OS X

[morsm]

Stack Overflow in network discovery on OS X

[richardschneider]

@morsm thanks for the bug report. The bug is that magic was added to determine a network changed event and is now causing infinite recursion on Catalina. I've changed the code to only do this magic on Windows.

Could use please build the catalina branch and test it on your machine. I don't have access to a Mac and Travis-CI doesn't yet support Catalina.

[morsm]

Hi @richardschneider , thanks for the quick turnaround!

I tested the fix and actually it doesn't work in my situation, because I'm running the standard .NET framework 4.6.1. Developing on Mac aiming to deploy to Raspberry Pi. So the #if statement still triggers the rebind code and the resulting stack overflow.

I changed it to this and then it works:

// Do magic only on Windows. #if NET461 if (Environment.OSVersion.Platform.ToString().StartsWith("Win")) // @morsm: not a great method, but RuntimeInformation not yet supported on 4.6.1 #else if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) #endif { NetworkChange.NetworkAddressChanged -= OnNetworkAddressChanged; NetworkChange.NetworkAddressChanged += OnNetworkAddressChanged; }

where you see I had to still use an #if because the 4.6.1 framework doesn't have the better RuntimeInformation class.

EDIT: sorry, I can't get the code formatting right above.

[richardschneider]

I've added your change. Could you fetch the catalina branch and test again?

[morsm]

That does it! Thanks a lot.