Giter Site home page Giter Site logo

Comments (3)

RickStrahl avatar RickStrahl commented on September 26, 2024

I can't reproduce that.

What I see:

  • Markdown doc open - preview pane closed

  • ctrl-n to open new editor

  • Editor opens with preview pane

  • Paste text

  • Text displays

  • Both editor and preview pane stay exactly the same

from markdownmonster.

RickStrahl avatar RickStrahl commented on September 26, 2024

Ok - so I figured out the issue here which is a little more complicated and involves actually two bugs:

  • The previous preview state is ignored and MM tries to refresh the preview when a new document is created
    This results in a new preview window being created which is what I saw. However, the new preview is not correctly attached to the editor, so any changes in the edit window actually fail.

  • When pasting the Preview Mode is explicitly enabled
    This results in a different problem - when the preview is not already visible, it sets the preview visible flag, but it's too late in the cycle to actually render. I think this is what you see: An empty preview pane.

Two fixes were made:

  • Only refresh the preview browser (and other related preview stuff) when the preview is actually visible when creating a new document

  • Only disable the preview if pasting a non-markdown document. For Markdown docs, respect the active preview visibility.

The final behavior is this:

  • When you add a Markdown document the preview visibility is respected (syntax by default is markdown)
  • Pasting into an empty doc only changes the preview status to invisible if non-markdown content is posted and the syntax changes to non-markdown

I think this fixes a long standing issue I've been trying to pinpoint but never figured out why it occurred, so thank you for that. I think this also caused some inconsistencies in the preview browser which show up in my logs.

from markdownmonster.

RickStrahl avatar RickStrahl commented on September 26, 2024

Fix in 3.2.17

from markdownmonster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.