Comments (1)
Hi!
First of all thank you all for providing such a nice library, it is a joy to use!
Thank you for using this library!
I just ran into a little trouble when creating a shared library on linux that linked against
libbit7z64.a
, which I created following the default build instruction in the readme. The errors looked similar to the ones described in this SO Question. TIL about position independent code.
Interesting! I never experienced this issue, probably because this library wasn't initially meant to be used inside a shared library.
Adding
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
to the top level CMakeLists.txt solved the issue for me.
Yeah, this fixes the issue indeed! However, as far as I understand, enabling PIC is not always desirable, so I don't think it should be enabled by default.
I just pushed a commit (a6248c0) that adds a BIT7Z_GENERATE_PIC
option (OFF
by default), which allows enabling the generation of Position Independent Code when building bit7z.
It seems like this would be relevant for a lot of other users, hence this issue. I wasn't sure if a pull request would be more suitable for this minor suggestion. Just let me know if you would prefer that.
No problem, it's just a minor change!
I hope to have helped.
Thank you for the feedback!
from bit7z.
Related Issues (20)
- [Bug]: Why can't compress an empty directory? HOT 5
- [Bug]:Rar file decompression progress is not accurate HOT 2
- [Feature Request]: provide an overwrite mode when decompressing the file HOT 1
- Library class undefined
- Failed to open archive HOT 3
- [Bug]: Filename contains Chinese chars ,app will crash!!!
- [Bug]: Link Problem when using BIT7Z_USE_NATIVE_STRING HOT 2
- [Feature Request]: nice api for ArchiveExtractCallback/ISequentialOutStream HOT 2
- [Feature Request]: nice api for using different output names during decompressing HOT 1
- [Feature Request]: Testing single entry or entries in archive HOT 1
- [Bug]: Some mistakes about macros HOT 3
- [Feature Request]: Allow parent cmakelists to specify external path to the lzma-sdk HOT 1
- [Bug]: split 7z files and bit7z::BitFormat::Auto HOT 3
- [Bug]: Could not deduce template argument for 'Input' HOT 3
- [Bug]: HRESULT_FROM_WIN32 in hresultcategory is a function and does not evaluate to a constant expression HOT 6
- [Feature Request]: Allow BitArchiveRead to be movable (not deleted) HOT 2
- [Bug]: Reading binary stream to determine file format code reading data exception HOT 1
- [Bug]: BIT7Z_AUTO_FORMAT is fail HOT 2
- [Bug]: bit7z::BitFormat::Zip extract Exception HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bit7z.