Comments (4)
Can you give me some steps on how to reproduce this?
I've used a version with that commit for a few weeks now and haven't run into any issues on Linux. I'm also not seeing any problems with the macOS version either.
from memento.
I finally found a reliable and portable way of reproducing this. Start Memento in windowed (not fullscreen) mode. Play this video from YouTube and select the Japanese subtitle. The subtitle widget displayed correctly. Fullscreen Memento, and the subtitle widget becomes transparent but still searchable on hover as described. Exit fullscreen and the widget continues to be transparent. A build on cb93730 does not have this bug.
Tested on macOS 12.0.1. Local and other videos are affected too (i.e., I downloaded the video and loaded it and could reproduce the bug).
from memento.
I don't have time to reproduce it right now, but if I had to guess it's going to be specific to macOS because updates are disabled when switching between fullscreen and windowed mode on macOS because Memento will hang otherwise. Since that code restores the old value of updatesEnabled, it is probably restoring a disabled value due to a race condition.
Rather than reverting the commit in question, I'll probably just ifdef the code out on macOS since it isn't strictly necessary. But this is just a guess pending further investigation. If it happens on other OSes, I'll revert it.
Thanks for the report.
from memento.
Thank you. I've read #7 before and understand that there have been issues with entering and exiting fullscreen on macOS. I am not able to test on other platforms at the moment but I think this is probably a good way of addressing this.
from memento.
Related Issues (20)
- Subtitle search only works when media is paused HOT 3
- [Feature request] Export only lowest frequency value HOT 1
- Memento fills empty fields with html HOT 1
- Play audio doesn't work HOT 1
- Can't open on MAC M3 Arm HOT 6
- what settings are needed for YouTube links to work? HOT 4
- Kanji Stroke Order font HOT 1
- [Feature Request] Glossary Selection Marker HOT 12
- [Feature Request] Subtitle Delay HOT 3
- MeCab UniDic support HOT 3
- QT6 migration causes subtitle position to shift when on screen controller is shown/hidden HOT 1
- Lack of Styling on Anki Cards Added via Memento HOT 4
- jp mining note support HOT 2
- Setting secondary_sub_visibility to 'auto' within the mpvacious plugin does not work HOT 2
- Any configuration guide? HOT 1
- Jellyfin mpv shim? HOT 16
- Video does not play HOT 4
- Improve popup dictionary styling HOT 5
- Partially visible video when using display scaling HOT 4
- Auto-resume video after finishing hovering over words? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memento.