Giter Site home page Giter Site logo

Comments (9)

nick-knight avatar nick-knight commented on July 18, 2024 3

I was formerly a strong proponent of the implicit-VL API, and a mild opponent of the explicit-VL API. I am now convinced that explicit-VL can provide better code generation, due to capabilities/limitations of current compilers. This is a practical argument, not a mathematical one, but that distinction is irrelevant to the performance programmer.

I am on board.

from rvv-intrinsic-doc.

rdolbeau avatar rdolbeau commented on July 18, 2024 1

Works for me (given previous discussion in e.g. #8 no surprise there ;-) ).

from rvv-intrinsic-doc.

kito-cheng avatar kito-cheng commented on July 18, 2024 1

Just to be sure: a function that wants to "set VL" and then restore the previous value would just vsetvl, pass the result to *_vl() ops, and the compiler takes care of restoring/setting other VL after returning?

In theory, you don't need to care about the VL register anymore if we only using explicit VL API, so yes, the compiler will handle that VL register restoring/setting, it's all compiler's responsibility now.

Also, is vse32_v_i32m4_vl(a, tmp); missing the last argument?

Updated, Thanks!

from rvv-intrinsic-doc.

kito-cheng avatar kito-cheng commented on July 18, 2024

Note: Corresponding PR will sent in next few days.

from rvv-intrinsic-doc.

jan-wassenberg avatar jan-wassenberg commented on July 18, 2024

@kito-cheng
Sounds good to me. This seems to match the direction taken by llvm-vp (adding VL and mask to IR ops). We have also seen some bugs caused by (manually) reordering intrinsics, which would not have happened if they were pure functions.

Just to be sure: a function that wants to "set VL" and then restore the previous value would just vsetvl, pass the result to *_vl() ops, and the compiler takes care of restoring/setting other VL after returning?

Also, is vse32_v_i32m4_vl(a, tmp); missing the last argument?

from rvv-intrinsic-doc.

kito-cheng avatar kito-cheng commented on July 18, 2024

Works for me (given previous discussion in e.g. #8 no surprise there ;-) ).

@rdolbeau Thanks your take a stand for this RFC!

from rvv-intrinsic-doc.

wuiw avatar wuiw commented on July 18, 2024

@kito-cheng, thanks for your sharing.

Same with @knightsifive, I was formerly a strong proponent of the implicit-VL API. However, this proposal convinces us. If possible, let this proposal being landing down asap.

from rvv-intrinsic-doc.

kito-cheng avatar kito-cheng commented on July 18, 2024

Here is the PR #64 for this RFC :)

from rvv-intrinsic-doc.

kito-cheng avatar kito-cheng commented on July 18, 2024

Corresponding changes are merged.

from rvv-intrinsic-doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.