Comments (37)
@rishipurwar1 Hi I am new to open source contribution, but I have 5years of experience working with Frontend Frameworks. I would like to work on this issue with some help. Thanks.
from frontendpro.
@yash-blmnm Assigned to you!
from frontendpro.
@rishipurwar1 I am unable to push the code to remote. Getting the error, 403 Forbidden
.
from frontendpro.
- I have added the Share Icon adjacent to Github URL and website URL.
- It opens a small container consisting of social icons with sharing URLs.
- The icons transform and scale up on hover.
- On clicking the social icons, a blank tab opens redirecting to the share window.
- The container closes on clicking outside.
- Attached are the images
from frontendpro.
Hey @yash-blmnm
Great Job
but Is it possible for you to convert it into a modal like this?
https://www.uidesigndaily.com/posts/sketch-share-post-social-day-913
I think the above looks much better and remove this google + icon and change it to LinkedIn and also add Reddit and discord button and place a Twitter icon in the first place and then discord.
And you also need to add a default intent.
For the Twitter share icon, you can do something like this: https://twitter.com/intent/tweet?text=Hello%20world, you just need to replace the text
query dynamically.
For more detail on tweet intent: https://developer.twitter.com/en/docs/twitter-for-websites/tweet-button/overview
text query could be:
**Hello Everyone!
I've just completed the "Random Quote Generator" CODINGSPACE Challenge.
Here's a link to my solution: https://www.codingspace.codes/solution/h1lgfjk1i7kiYmRA4MtA
Any feedback and suggestions on how I can improve are very welcome!**
from frontendpro.
You need to break this task down, first work on building this modal and then show me how it looks then proceed further.
If you need any help, feel free to ping me.
from frontendpro.
@rishipurwar1
I have built a sample modal for the share icons. Please share your thoughts
Also, is there any other social platform needed to be added to the list?
from frontendpro.
@rishipurwar1 I have built a sample modal for the share icons. Please share your thoughts
Also, is there any other social platform needed to be added to the list?
Great Job!
Looks really good to me
Here is my feedback:
- Add Reddit icon
- In the copy link section, you need to put the link of the codingspace solution, not the website link.
- Change the background color to some dark to match our dark theme. (see other models on our website for reference i.e when we download a challenge)
- Add hover effect on icons(You can change the border color to purple, similar to this profile border.
and Can we use "Share your solution" instead of "Share solution"? What sounds good to you?
Overall it looks great.
from frontendpro.
@yash-blmnm any updates on this?
from frontendpro.
Is there anything that needs to be solved regarding the share solution button?
from frontendpro.
@rishipurwar1 I want to work on this. I have been working on web development for 2 years, but this is my first time for open source contribution. I would like to do this task.
from frontendpro.
@rishipurwar1 I have built a sample modal for the share icons. Please share your thoughts
Also, is there any other social platform needed to be added to the list?Great Job! Looks really good to me
Here is my feedback:
- Add Reddit icon
- In the copy link section, you need to put the link of the codingspace solution, not the website link.
- Change the background color to some dark to match our dark theme. (see other models on our website for reference i.e when we download a challenge)
- Add hover effect on icons(You can change the border color to purple, similar to this profile border.
- When someone clicks on the copy to clipboard button, it should show link copied(but this task is completely optional if you have time then only do this task)
and Can we use "Share your solution" instead of "Share solution"? What sounds good to you?Overall it looks great.
@yash-blmnm have you fixed the above issues?
from frontendpro.
Is there anything that needs to be solved regarding the share solution button?
@yash-blmnm already working on this one.
You can pick a different issue.
from frontendpro.
@rishipurwar1 Almost completed with the solution. I Will update tonight.
from frontendpro.
ok
from frontendpro.
Hi @rishipurwar1 Please review if these changes are okay.
One more varient for hover
from frontendpro.
Really looks good to me.
Just to confirm Is it vertically and horizontally centered?
And one more thing what happens when you click on these social icons like Twitter. Ideally, these buttons should have default intent. For example, the Twitter button should have a default tweet embedded in a button, so, when you click on Twitter, it opens a Twitter website and has a default tweet on it something like this
Hello Everyone!
I've just completed the "Random Quote Generator" CODINGSPACE Challenge.
Here's a link to my solution: https://www.codingspace.codes/solution/h1lgfjk1i7kiYmRA4MtA
Any feedback and suggestions on how I can improve are very welcome!
You can check this random quote generator, you'll get the idea: https://quotegeneratorapp.netlify.app/
And after making the above changes, please make a PR for this, but only commit those files in which you made changes.
from frontendpro.
If you need any help in embedding default text in these buttons, please do let me know. This feature is going to be an important feature for the users.
from frontendpro.
You can make use of this package: https://www.npmjs.com/package/react-share but this package doesn't include a discord button. I think we can make this thing without using this package, just need to think a little bit.
from frontendpro.
@rishipurwar1
Just to confirm Is it vertically and horizontally centered?
-
Yes I have aligned them using flex and justified using `space-between. so the addition or removal of icons doesn't impact the design.
-
On clicking any icon, the users are taken to the respective sharing pages.
Eg.
If you need any help in embedding default text in these buttons, please do let me know. This feature is going to be an important feature for the users.
- Yes, I am able to redirect to the Linkedin Sharing page, and Url is embedded, but the summary is not getting embedded. The URL I am using is
https://www.linkedin.com/sharing/share-offsite?url=${url}&summary=${text}
- How to add a Link for the Discord share Icon?
from frontendpro.
@rishipurwar1 Should we also provide a text box for the users to edit the summary/text before they select any sharing options?
Just a suggestion from the user's point of view.
from frontendpro.
- but the summary is not getting embedded. The URL
Please check this StackOverflow post: https://stackoverflow.com/questions/10713542/how-to-make-a-custom-linkedin-share-button
May help you
from frontendpro.
- How to add a Link for the Discord share Icon?
I don't think we have a way to do that. Any ideas what we can do instead of this?
from frontendpro.
and is facebook one working fine?
from frontendpro.
@rishipurwar1 Should we also provide a text box for the users to edit the summary/text before they select any sharing options? Just a suggestion from the user's point of view.
Good Idea!
Where do you want to place this text box?
from frontendpro.
- For Linkedin, I followed the StackOverflow post, yet it is not displaying the title or summary as expected. I think it is expected behavior.
Also in react-share code, they have used only the URL in LinkedIn Share Button
https://github.com/nygardk/react-share/blob/master/src/LineShareButton.ts
nygardk/react-share#184 - Discord - Could we add the invite link here?
- Facebook is working fine i.e the test is displayed in Facebook
- Please find a sample Text box to edit summary
from frontendpro.
Yes! we can add the discord invite link for now
and the text summary looks good. Can we add this text box below the copy link?
Is it possible to add a link to a particular channel of our discord server i.e share-your-solutions?
and please test your changes on different screen sizes.
@rishipurwar1 Should we also provide a text box for the users to edit the summary/text before they select any sharing options? Just a suggestion from the user's point of view.
Good Idea! Where do you want to place this text box?
Yes! we can add the discord invite link for now
Is it possible to add a link to a particular channel of our discord server i.e share-your-solutions?
from frontendpro.
- Please find a sample Text box to edit summary
and the text summary looks good. Can we add this text box below the copy link?
and please test your changes on different screen sizes.
from frontendpro.
- Adding Text summary below Copy Link. Also, as you could see, made the modal responsive.
- Discord Link - I have not used Discord before, but I could see from the documentation that we could create invite links to private channels.
https://discord.com/moderation/360060481813-103:-Basic-Channel-Setup
from frontendpro.
- Adding Text summary below Copy Link. Also, as you could see, made the modal responsive.
- Discord Link - I have not used Discord before, but I could see from the documentation that we could create invite links to private channels.
https://discord.com/moderation/360060481813-103:-Basic-Channel-Setup
Looks really good!
For now! Add a discord invite link because we want users to share their solutions on public channels not on private channels.
and make a pr to the development branch and only commit those files in which you made changes.
from frontendpro.
@yash-blmnm any updates on this?
from frontendpro.
Hi @rishipurwar1 I compiled all my changes. But I am still unable to push to remote.
from frontendpro.
from frontendpro.
@rishipurwar1 any updates regarding this?
from frontendpro.
Hello @yash-blmnm sorry for the late reply
I think you're directly pushing the changes on my repo.
Have you forked my repo?
from frontendpro.
from frontendpro.
No, I am using one cloned using SSH.
…
On Tue, Nov 2, 2021 at 5:17 PM Rishi Purwar @.***> wrote: Hello @yash-blmnm https://github.com/yash-blmnm sorry for the late reply I think you're directly pushing the changes on the repo. Have you forked my repo? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#122 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRCY2742IJJOPKSQNSF3Y3UJ7FVBANCNFSM5FL4T76A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
First, create a fork of my repo and then clone the forked repo! it should work.
from frontendpro.
Related Issues (20)
- Fix footer spacing HOT 9
- Add Hover Effect for Github Sign up Button HOT 6
- Is there anyway I can contribute in this project? HOT 2
- Add a hover effect on any card HOT 11
- The website should use react-firebase-hooks to clean the code HOT 4
- On click profile modal should get close HOT 25
- Add hover effect to profile modal links HOT 2
- On click outside side navbar need to be closed in mobile view
- Add css style to scrollbar HOT 3
- Community Exchange Introduction/Tracking HOT 1
- Login modal design is broken and not closable at small screen. HOT 2
- Delete modal is not visible HOT 11
- Profile photo modal not completely visible on mobile screen. HOT 3
- Add a loading indicator to the delete button HOT 6
- Coding Playground integration
- Coding Playground integration
- Migration to NextJs
- Downloading Other Challenge Starter Code HOT 4
- Duplicate Challenge in "In-Progress Challenges" Section HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontendpro.