Running citellus against non openstack wrongly identifies node as controller

[risuorg]

Running citellus against non openstack wrongly identifies node as controller

[zerodayz]

If we don't specify any --plugin during the execution the code expects the node is OpenStack node

https://github.com/zerodayz/citellus/blob/master/citellus#L146-#L149

I will try to fix that by setting the OpenStack node only if the RPMs are found in the installed-rpms. Otherwise it will run the generic checks from the system plugin which I will add.

[zerodayz]

Workaround so we use system plugin: 9a61cf8

We need to re-think the way we run plugins.

[zerodayz]

Fixed in 488d300

The way it works now:

1. If we are not able to find any openstack-nova-common and PLUGIN (defined on CLI by --plugin or -p) is empty then run against "system"

2. If we are able to find openstack-nova-common and PLUGIN (defined on CLI by --plugin or -p) is empty then run against "openstack"

3. If we specify with --plugin or -p different plugin which exists for example openstack we can override this. However it will fail anyway but allows override.