[BUG] Argon 2 error - function depreciation leads to 500

[dsignr]

[BUG] Argon 2 error - function depreciation leads to 500

[riverrun]

Glad to hear it's now fixed. I will close this issue now. I have made a few changes to the UPGRADE guide to make things a little clearer.

[riverrun]

Version 2.1 of Phauxth is now using version 5 of Comeonin, and the main change, as far as Phauxth is concerned, is that Comeonin is now not called directly.

The changes you will need to make are:

• change Comeonin.Argon2 in the config file to Argon2
• change Comeonin.Argon2.add_hash to Argon2.add_hash

I added a note about this to the Gitter channel and updated the UPGRADE_v2 guide, but it's not always easy to let everyone know when there is a change.

[dsignr]

Thanks David, I missed that. Probably because I was already on 2.0.0 so, must have totally missed it.
Ok, I fixed as you have mentioned and now I'm being hit with this:

Request: POST /api/core
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in MyAppWeb.Auth.Login.report/2
        (myapp) lib/myapp_web/auth/login.ex:7: MyAppWeb.Auth.Login.report(:ok, [])

Inside my auth/login.ex:

defmodule MyAppWeb.Auth.Login do
  @moduledoc """
  Custom login module that checks if the user is confirmed before
  allowing the user to log in.
  """

  use Phauxth.Login.Base

  alias Comeonin.Argon2
  alias MyApp.IAM

  @impl true
  def authenticate(%{"password" => password} = params, _, opts) do
    case IAM.get_by(params) do
      nil -> {:error, "no user found"}
      %{confirmed_at: nil} -> {:error, "account unconfirmed"}
      user -> Argon2.check_pass(user, password, opts)
    end
  end
end

Seems like a struct mismatch within the report function. I can probably override it, but not sure it is a bug..

[dsignr]

Ok, I found out the issue. In this callback:

@impl true
 def authenticate(%{"password" => password} = params, _, opts) do
    case IAM.get_by(params) do
      nil -> {:error, "no user found"}
      %{confirmed_at: nil} -> {:error, "account unconfirmed"}
      user -> Argon2.check_pass(user, password, opts)
   end
end 

The success case returns just :ok, instead of the tuple {:ok, user} that the report function is expecting.

@impl true
 def authenticate(%{"password" => password} = params, _, opts) do
    case IAM.get_by(params) do
      nil -> {:error, "no user found"}
      %{confirmed_at: nil} -> {:error, "account unconfirmed"}
      user -> {Argon2.check_pass(user, password, opts), user} # <---  Changing it to this solved it
   end
end

Since it's a callback implementation, I don't think it's a bug per se, but then again, I'm upgrading from Phauxth 2.0.0 to 2.1.0, so my implementation hasn't changed, but seems like, as you have mentioned, the Argon function has changed.

[riverrun]

You need to remove the alias Comeonin.Argon2 line

[riverrun]

This commit shows the changes that I made to the example app to upgrade it to 2.1

[dsignr]

You need to remove the alias Comeonin.Argon2 line

That was it! I can confirm this was the issue. Thanks David. Should I close this issue now?

[dsignr]

Thank you David!