Add Code Style eval vars

[rizinorg]

Add Code Style eval vars

[ITAYC0HEN]

Can you pleased share a screenshot with the problematic things? And draw some arrows. Would help to focus on what to fix

…

On Sun, Aug 18, 2019, 19:02 radare ***@***.***> wrote: so much newlines and missing braces, and define+assign in the same line instead of having all the vars on top — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEZ7M4W7RENZ3CX6XSH35L3QFFXAFANCNFSM4IMTMRSQ> .

[radare]

lazy to use the pencil here,

    iVar2 = func_0x000100004510();

should be

    int32_t iVar2 = func_0x000100004510();

[radare]

also .

if ()
{
...
}
else
{
...
}

should be

if (x) {
} else {
}

[radare]

missing space before (

            iVar2 = func_0x00010000450a();

...etc everything is documented in r2's DEVELOPERS.md

[radare]

maybe as an option or sthg, i understand not everybody likes r2 coding style, but imho this way is more readable, thats why we have been evolving the r2 coding style for 13 years with discussions and comparisons

[thestr4ng3r]

The options are all here:
https://github.com/thestr4ng3r/r2ghidra-dec/blob/90e393dffc5656fbe7fe6204b191027a255b29d5/src/core_ghidra.cpp#L66-L72
Just need to add eval vars.
But as long as they are not there, I dictate the style without discussion :-P

[radare]

see how r2dec adds and handles eval vars

…

On 18 Aug 2019, at 20:49, Florian Märkl ***@***.***> wrote: The options are all here: https://github.com/thestr4ng3r/r2ghidra-dec/blob/90e393dffc5656fbe7fe6204b191027a255b29d5/src/core_ghidra.cpp#L66-L72 <https://github.com/thestr4ng3r/r2ghidra-dec/blob/90e393dffc5656fbe7fe6204b191027a255b29d5/src/core_ghidra.cpp#L66-L72> Just need to add eval vars. But as long as they are not there, I dictate the style without discussion :-P — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG75FS6WP6UIUDDTO6CNCLQFGKSBANCNFSM4IMTMRSQ>.