New BatchPolopt won't run

[rll]

New BatchPolopt won't run

[singulaire]

In addition to this, BatchSampler seems to not implement the obtain_samples() function. on fixing the typo locally, I encounter:

Traceback (most recent call last):
File "/home/tom/rllab/scripts/run_experiment_lite.py", line 103, in
run_experiment(sys.argv)
File "/home/tom/rllab/scripts/run_experiment_lite.py", line 90, in run_experiment
maybe_iter = concretize(data)
File "/home/tom/rllab/rllab/misc/instrument.py", line 898, in concretize
return method(_args, *_kwargs)
File "/home/tom/rllab/rllab/algos/batch_polopt.py", line 244, in train
paths = self.sampler.obtain_samples(itr)
File "/home/tom/rllab/rllab/sampler/base.py", line 19, in obtain_samples
raise NotImplementedError
NotImplementedError

When trying to run several of the TRPO examples.

[dementrock]

@jachiam @singulaire Really sorry about this. Should be fixed by 25f38dc

[alexbeloi]

There were a couple lines that got cut off when @dementrock did a refactoring after my pull request. It should be fixed when the pull request is merged, or you can apply this patch.

From 7ed6ea686478d31fe53781be2ef81cdcf3a1c9ac Mon Sep 17 00:00:00 2001
From: Alex Beloi <[email protected]>
Date: Thu, 23 Jun 2016 09:52:12 -0700
Subject: [PATCH] fix: missing lines from refactoring BatchPolopt

---
 rllab/algos/batch_polopt.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/rllab/algos/batch_polopt.py b/rllab/algos/batch_polopt.py
index 5aac591..77d0f4b 100644
--- a/rllab/algos/batch_polopt.py
+++ b/rllab/algos/batch_polopt.py
@@ -21,9 +21,13 @@ class BatchSampler(Sampler):

     def shutdown_worker(self):
         parallel_sampler.terminate_task(scope=self.algo.scope)
+
+    def obtain_samples(self, itr):
+        cur_params = self.algo.policy.get_param_values()
+        paths = parallel_sampler.sample_paths(
+            policy_params=cur_params,
             max_samples=self.algo.batch_size,
             max_path_length=self.algo.max_path_length,
-            scope=self.algo.scope,
         )
         if self.algo.whole_paths:
             return paths
-- 
1.9.1

[dementrock]

Closing this as it should be fixed now.