Giter Site home page Giter Site logo

Comments (4)

rm-code avatar rm-code commented on July 4, 2024

Thanks for the suggestion. I'm currently a bit occupied with real life and my main development machine broke down, so it'll be a while before I can take a look into it (probably August).

from love-atom.

pablomayobre avatar pablomayobre commented on July 4, 2024

I think that dropping the dependency on the language package should be better.

Dependencies should be packages that are required for this package to work. But the language package isn't and it can be installed by the user later on.

A suggestion on the readme would be better than having language-lua as a dependency

from love-atom.

rm-code avatar rm-code commented on July 4, 2024

Dependencies should be packages that are required for this package to work. But the language package isn't and it can be installed by the user later on.

Yes I agree. IIRC it was needed to get the snippets back to work in one of the earlier versions, but I might be wrong.

Anyway, I'll remove the dependency.

from love-atom.

rm-code avatar rm-code commented on July 4, 2024

I decided against removing language-lua as a dependency for now. I updated the README with instructions on how to use a custom language package.

The main reason is that language-lua is the standard for working with Lua in Atom and love-atom requires a language package of some kind. Removing it would mean that other users would have to manually install language-lua.

from love-atom.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.