Comments (4)
I just was testing and saw this behaviour, I was under the impression this is what the pidfile is meant to address (but it never gets created in my case).
from dvcs-autosync.
Writing pid file with default name derived from config file and preventing duplicate startup with same pid file implemented in commit d85965a
from dvcs-autosync.
- this is a violation of the xdg basedir spec.
pid files do not belong in directories for configuration.
instead of merely taking the filename of the config file and appending .pid, I propose:
- make user configure a directory where all pidfiles will go (maybe default to $XDG_CACHE_HOME/dvcs-autosync)
- store pidfiles in that directory, using the basename of the config (stripped of any extensions) as basename for the pidfile.
So,
/home/dieter/.config/dvcs-autosync/somedirectory.conf
would give:
/home/dieter/.cache/dvcs-autosync/somedirectory.pid
- there should be a way to make autosync either:
- just kill another autosync instance which is using the same config
- kill another autosync instance which is using the same config, and replace it.
currently autosync-xdg-launcher.sh implements this in bash by inspecting the arguments of running autosync instances, but implementing it in the python code itself would be more robust, and more useful (for other use cases, like a user manually killing specific autosync instances)
from dvcs-autosync.
To really fix this issue, it would need to be handled on all platforms, and I don't yet know how to do that without yet another platform dependent piece of code. Are you aware of a standard module that would allow to handle PID-style locking on all platforms?
from dvcs-autosync.
Related Issues (17)
- syncmethod = none should not raise an error notification HOT 2
- loglevel should be configurable HOT 2
- there should be a "safetycheckcmd" to avoid trying to commit in some cases HOT 1
- Use of logger in stead of logging causes crash on improper configuration HOT 3
- Only last change after $readfrequency gets synced
- dvcs-autosync push instead of pull HOT 4
- ImportError: No module named jabberbot HOT 1
- decide on which bugtracker to use HOT 4
- cannot launch again if pid written in .pid file is used by another process HOT 4
- SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol
- Is this project abandoned? HOT 1
- Website links to wrong repo and issue tracker HOT 1
- show warning/error notifications when commands fail HOT 2
- dvcs-autosync incorrectly records changes on a file `4913` HOT 6
- jabberbot ignores messages from other clients HOT 4
- Add syncmethod = none HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dvcs-autosync.