Giter Site home page Giter Site logo

Comments (5)

rmcelreath avatar rmcelreath commented on July 22, 2024

Seems like Stan changed something about how warmup and/or sampling works. If you set control=list(adapt_delta=0.99), the spike goes away with modest samples. So that suggests a change to warmup algorithm.

I don't understand why the results should differ, however, once the adaptation is adjusted.

I can't get the same random data from the provided seed, in any event. I can't imagine anything changed with the way the seed is used. So I must have used a different seed for the example shown in 13.4 and 13.5. I'll see if I figure it out.

from rethinking.

mrdevlar avatar mrdevlar commented on July 22, 2024

Thanks the adaptive_delta seems to have eliminated the spike. I initially expected that the mass at 0 was shifting the distribution's MAP, but it seems with the adaptive_delta it is still at:

               Mean StdDev lower 0.89 upper 0.89 n_eff Rhat
Rho[1,1]       1.00   0.00       1.00       1.00  6000  NaN
Rho[1,2]      -0.18   0.33      -0.71       0.33  2211 1.00
Rho[2,1]      -0.18   0.33      -0.71       0.33  2211 1.00
Rho[2,2]       1.00   0.00       1.00       1.00  6000 1.00

Rather bizarre. Just to make sure I am understanding this correctly, I should expect Rho[1,2], Rho[2,1] to be -0.7 yes? As the original Rho matrix we defined earlier:

sigmas <- c(sigma_a,sigma_b) # standard deviations
Rho <- matrix( c(1,rho,rho,1) , nrow=2 ) # correlation matrix

Returns:

     [,1] [,2]
[1,]  1.0 -0.7
[2,] -0.7  1.0

Right? Or am I missing something?

from rethinking.

rmcelreath avatar rmcelreath commented on July 22, 2024

I think the provided seed in the text won't reproduce Figure 13.4. That's an issue. I should figure out which random seed will reproduce that figure.

But we shouldn't expect any particular simulation to recover the "true" correlation of -0.7. Many simulated sets of data will produce a milder empirical correlation than that, and then the finite evidence will lead to regularization towards a less strong correlation.

from rethinking.

paul-buerkner avatar paul-buerkner commented on July 22, 2024

I think the Stan team recently changed the default of adapt_delta from 0.95 to 0.8, which may explain the convergence problems. Apart from that, adapt_delta = 0.8 should work ok when using the non-centered parameterizations.

When trying to get reliable estimates of random effects correlations, n = 20 (for the cafes) will likely not suffice. Also lkjcorr(2) pulls the estimates somewhat towards zero. As long as rho = -0.7 is in the 95% credible interval (when using Rho ~ lkjcorr(1)) I wouldn't worry too much.

from rethinking.

lexmart avatar lexmart commented on July 22, 2024

set.seed(4) instead of set.seed(5) gives me roughly the same plot as figure 13.4 (1st edition)

from rethinking.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.