rmcgirr83/nationalflags

phpBB extension that allows users to be able to choose a national flag and have a top (those with the most users selecting the flag) number of flags display on the index page of a phpBB forum. Requires at least phpBB version 3.3.

nationalflags's Issues

Error Log (PHP Fatal error)

I have version 1.3.1 of this extension installed on my site. (The one that is offered at phpbb.com). I haven't tried testing your latest commit changes or etc.

Just caught this error in my Error Logs for this extension:

[20-Sep-2016 16:17:03 America/Toronto] PHP Fatal error: Uncaught exception 'Symfony\Component\Routing\Exception\InvalidParameterException' with message 'Parameter "flag_id" for route "rmcgirr83_nationalflags_getflags" must match "[^/]++" ("" given) to generate a corresponding URL.' in phpbb/vendor/symfony/routing/Symfony/Component/Routing/Generator/UrlGenerator.php:163 Stack trace: #0 phpbb/vendor/symfony/routing/Symfony/Component/Routing/Generator/UrlGenerator.php(136): Symfony\Component\Routing\Generator\UrlGenerator->doGenerate(Array, Array, Array, Array, Array, 'rmcgirr83_natio...', false, Array) #1 phpbb/phpbb/controller/helper.php(188): Symfony\Component\Routing\Generator\UrlGenerator->generate('rmcgirr83_natio...', Array, false) #2 phpbb/ext/rmcgirr83/nationalflags/event/listener.php(366): phpbb\controller\helper->route('rmcgirr83_natio...', Array) #3 [internal function]: rmcgirr83\nationalflags\event\listener->viewtopic_modify_pos in phpbb/vendor/symfony/routing/Symfony/Component/Routing/Generator/UrlGenerator.php on line 163

Invalid services.yml file

The Extensions .yml Files Syntax Check extension identifies services.yml file as invalid.... Yet i have the latest National Flags extension.
I tried replacing the single quotes to double quotes but its still claiming the file is invalid.

Here is my file:

imports:
    - { resource: tables.yml }
    - { resource: flag_constants.yml }

services:
    rmcgirr83.nationalflags.admin.controller:
        class: rmcgirr83\nationalflags\controller\admin_controller
        arguments:
            - "@cache"
            - "@config"
            - "@dbal.conn"
            - "@pagination"
            - "@controller.helper"
            - "@request"
            - "@template"
            - "@user"
            - "@log"
            - "@ext.manager"
            - "@path_helper"
            - "%core.root_path%"
            - "%core.php_ext%"
            - "%flag_constants%"
            - "%rmcgirr83.nationalflags.table.nationalflags%"
            - "@rmcgirr83.nationalflags.nationalflags"
            - "@files.factory"
            - "@filesystem"
            - "@language"

    rmcgirr83.nationalflags.main.controller:
        class: rmcgirr83\nationalflags\controller\main_controller
        arguments:
            - "@auth"
            - "@config"
            - "@dbal.conn"
            - "@pagination"
            - "@controller.helper"
            - "@language"
            - "@request"
            - "@ext.manager"
            - "@path_helper"
            - "@template"
            - "@user"
            - "%core.root_path%"
            - "%core.php_ext%"
            - "%rmcgirr83.nationalflags.table.nationalflags%"
            - "@rmcgirr83.nationalflags.nationalflags"
            - "@files.factory"

    rmcgirr83.nationalflags.listener:
        class: rmcgirr83\nationalflags\event\listener
        arguments:
            - "@auth"
            - "@config"
            - "@controller.helper"
            - "@dbal.conn"
            - "@language"
            - "@request"
            - "@template"
            - "@user"
            - "@ext.manager"
            - "%core.root_path%"
            - "%core.php_ext%"
            - "@rmcgirr83.nationalflags.nationalflags"
        tags:
            - { name: event.listener }

    rmcgirr83.nationalflags.nationalflags:
        class: rmcgirr83\nationalflags\core\nationalflags
        arguments:
            - "@config"
            - "@controller.helper"
            - "@cache"
            - "@dbal.conn"
            - "@language"
            - "@template"
            - "@user"
            - "%rmcgirr83.nationalflags.table.nationalflags%"
            - "@ext.manager"
            - "@path_helper"
            - %flag_constants%
            - "@?phpbb.collapsiblecategories.operator"

Warnings in ACP

Hello,

Warnings in the ACP:
[phpBB Debug] PHP Warning: in file [ROOT]/ext/rmcgirr83/nationalflags/controller/admin_controller.php on line 567: Invalid argument supplied for foreach()
[phpBB Debug] PHP Warning: in file [ROOT]/ext/rmcgirr83/nationalflags/controller/admin_controller.php on line 571: array_multisort(): Argument #1 is expected to be an array or a sort flag
[phpBB Debug] PHP Warning: in file [ROOT]/ext/rmcgirr83/nationalflags/controller/admin_controller.php on line 573: implode(): Invalid arguments passed
Pierre Duhem

Move cache generation code into core.page_header

User with 272k user with flags is getting debug notices due to cache of user_and_flags...move it from core.user_setup event to core.page_header. No idea if it will work but worth a shot.

how to add the flag to the viewtopic and other parts of the forum

how would i go about adding the flags to a custom style like the pics i got it on the index page but it wont show on posts

L’extension sélectionnée ne peut pas être activée. Veuillez en vérifier les prérequis.

Hello,

php 5.6
phpbb 3.2.0

why i get this error when active this extension ?

Thanks

problem with 3.2

hi i have this message on 3.2

Fatal error: Can't use method return value in write context in /home2/costanzo/public_html/ext/rmcgirr83/nationalflags/controller/admin_controller.php on line 587

Change $flags_array to $flags

https://github.com/rmcgirr83/phpBB-3.1-nationalflags/blob/c317bf4cd2a9b5910dc2030a183c39bb2471d55f/core/nationalflags.php#L112

Flags array doesn't exist and if using a lang entry other than en without translating, errors present themselves.

NK & KS flags

Hi @rmcgirr83,

• nk.png should be: https://github.com/RMcGirr83/phpBB-3.1-nationalflags/blob/master/flags/kp.png (source: https://en.wikipedia.org/wiki/ISO_3166-2:KP)
• ks.png should be: https://github.com/RMcGirr83/phpBB-3.1-nationalflags/blob/master/flags/kr.png (source: https://en.wikipedia.org/wiki/ISO_3166-2:KR)