Comments (3)
The problem in this case is that there methods named symbol and type_ for the getters, so we get a warning of shadowing an existing declaration.
from evm.
What if we renamed it then? Maybe to baseType_
? This shouldn't impact any contracts importing it, so it would just make the variable easier to read.
from evm.
The getter was renamed in the end and we made sure only mandatory trailing scores were left.
from evm.
Related Issues (20)
- When overwrites, forget to delete the corresponding element in `activeResourcePriorities` HOT 3
- maxSupply: possibility to mint unlimited number of NFTs HOT 2
- A friendly reminder that the small problem in LISENSE HOT 1
- Should `SetEquippableToAll(uint64 indexed partId)` be emitted when `_addEquippableAddresses` etc? HOT 3
- `RMRKCatalog` has no way to set `metadataURI` HOT 2
- Equipping into an NFT with 2 resources of same base HOT 15
- Add transferable flag HOT 1
- unused function parameter HOT 5
- Cannot install `rmrk-team/evm-contract` HOT 2
- Some questions about `MultiResource_EIP` in `eip` branch HOT 3
- Feature request: emit eip-4906 MetadataUpdate event when primary asset changes HOT 2
- Catalog implementation with a mapping and method to get all partIds HOT 2
- Duplicate check is needed in `addChild` HOT 4
- `safeNestTransfer` is redundant HOT 6
- Move the Etherscan verification istructions from Ropsten to Görli
- Should revert when try to transfer NFT to itself HOT 2
- After `_unnestChild`, position of exchanged child(last child) in `_posInChildArray` is not updated HOT 3
- Should `reclaimChild` need to check the child is not in `_pendingChildren` and `_children`? HOT 2
- Will that be more direct and intuitive if set the uninitialized priority to `2^16 - 1` in `_acceptChild`? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evm.