Errors from adding a null field to an index are hard to diagnose.

[rnewson]

Errors from adding a null field to an index are hard to diagnose.

[rnewson]

I should report a better error but I don't think I should attempt to fix broken JavaScript.

[nateroling]

I don't think dealing with null values gracefully is attempting to fix broken Javascript. Unless there's a useful reason to die on null fields that I'm not seeing, I'd call it being robust.

A better error message would help, but I don't see why it should be a problem the user is forced to deal with. Especially because it might not come up until after the code is in production, when a null value slips in unintentionally.

[rnewson]

I'll change it to match couchdb itself. That is, I'll report the javascript error on a per-document basis but index those documents that don't throw errors.

couchdb logs this under the same circumstance;

[info] [<0.85.0>] OS Process :: function raised exception (Cannot encode 'undefined' value as JSON) with doc._id part-1

I cannot detect or correct all javascript errors and so I would rather not detect or correct any. I will report the error and make it only affect the individual document.

[rnewson]

I pushed a quick change that should improve behavior. I still need to work on some edge cases.

[rnewson]

Seems to be fine, please reopen or file an issue if you find other such cases.