Comments (4)
@igoryan-k Hi Igor-
Can you test this fiddle out? http://jsfiddle.net/rniemeyer/V4m5K/2/ The only change is that the templates have any top-level text nodes (whitespace/carriage returns) removed in the script tags. The extra text nodes can cause issues, as after the cancel the nodes are no longer in the right order.
I don't think that it would really hurt to make the change that you suggested. As you mentioned, it is just the same logic that happens when the item is actually dropped. Might even be able to just set the targetIndex
to the sourceIndex
when a drop is cancelled and then let it pass through the normal logic. I will give it a little thought.
from knockout-sortable.
Hi Ryan,
Sorry for the long response.
Thanks for explanation and example. Your solution works, so I removed my fix and now using the original version in the final code.
There is another solution - I had to go away from named templates to anonymous templates and put the 'li' template inside the 'ul' markup. That also fixed the problem, even having the whitespace/carriage returns in 'li' element.
Here is an example http://jsfiddle.net/igoryan/V4m5K/4/
So the issue only persists for named templates.
Regards,
Igor
from knockout-sortable.
@igoryan-k oh yes, I have some code that strips the top-level text nodes from anonymous templates. It is not so easy to do that with named templates unfortunately. When I get a chance, I may still consider making this change. As I mentioned, it wouldn't be bad to just set the targetindex equal to the sourceIndex and let it go through the normal logic.
from knockout-sortable.
Templates now get extra text nodes stripped.
from knockout-sortable.
Related Issues (20)
- observableArray extended with deferred: true removes items from list HOT 2
- Draggable Incorrectly calls template init/update
- Using droppable next to a sortable
- Draggable Droppable Issue
- sortable dissapears after first drop HOT 4
- knockout-sortable not re-rendering when dragging to same index
- Sortable not working with latest jquery HOT 3
- Input and textarea cannot be selected in Firefox 40
- sortable behaviour inconsistent with droppable/draggable
- Confirmation popup before aftermove is executed HOT 1
- Sortable not working after upgrading to knockout 3.5 HOT 10
- anonymous templates will break in next version of knockout HOT 3
- droppable options drop event issue
- Does not work with knockout 3.5.0 HOT 2
- Problem after upgrading ko to 3.5.1 HOT 3
- Nested sortable support
- knockout-sortable drag and drop not working in Windows touch devices
- Get an error after clean data HOT 3
- JS error introduced by v1.2.1 "Fixed draggable and droppable disposal" HOT 1
- disableSelection on sortable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knockout-sortable.