Giter Site home page Giter Site logo

Comments (4)

rniemeyer avatar rniemeyer commented on July 18, 2024

@igoryan-k Hi Igor-

Can you test this fiddle out? http://jsfiddle.net/rniemeyer/V4m5K/2/ The only change is that the templates have any top-level text nodes (whitespace/carriage returns) removed in the script tags. The extra text nodes can cause issues, as after the cancel the nodes are no longer in the right order.

I don't think that it would really hurt to make the change that you suggested. As you mentioned, it is just the same logic that happens when the item is actually dropped. Might even be able to just set the targetIndex to the sourceIndex when a drop is cancelled and then let it pass through the normal logic. I will give it a little thought.

from knockout-sortable.

igoryan-k avatar igoryan-k commented on July 18, 2024

Hi Ryan,
Sorry for the long response.
Thanks for explanation and example. Your solution works, so I removed my fix and now using the original version in the final code.

There is another solution - I had to go away from named templates to anonymous templates and put the 'li' template inside the 'ul' markup. That also fixed the problem, even having the whitespace/carriage returns in 'li' element.
Here is an example http://jsfiddle.net/igoryan/V4m5K/4/

So the issue only persists for named templates.

Regards,
Igor

from knockout-sortable.

rniemeyer avatar rniemeyer commented on July 18, 2024

@igoryan-k oh yes, I have some code that strips the top-level text nodes from anonymous templates. It is not so easy to do that with named templates unfortunately. When I get a chance, I may still consider making this change. As I mentioned, it wouldn't be bad to just set the targetindex equal to the sourceIndex and let it go through the normal logic.

from knockout-sortable.

rniemeyer avatar rniemeyer commented on July 18, 2024

Templates now get extra text nodes stripped.

from knockout-sortable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.