Comments (8)
@jofri Thanks for reporting this one. I can see the issue and how to address it. Will put a fix in this weekend.
from knockout-sortable.
@jofri - put in a fix for this issue. Let me know how it looks for you. Here is your fiddle with the latest code: http://jsfiddle.net/rniemeyer/qvrwy/1/.
from knockout-sortable.
Why not just do it this way (computed returns array instead of observable array)?
http://jsfiddle.net/mbest/qvrwy/2/
from knockout-sortable.
@mbest that is a fine idea, but it doesn't work in his case. The sortable binding doesn't want the unwrapped observableArray, as it needs to write back to it. In your fiddle, if you sort your items on top, they will not be reflected on the bottom.
In a lot of the bindings that I have worked on, I have avoided the update function completely and used very specific computed observables in the init. However, there are cases where the subscription only happens in the parsing of the binding string that this will not account for.
For example, in some cases people might want to use a function (not a computed observable) to return a value, because they need to call the same logic several times and want to pass a different argument into each (put myFunction(someArg)
in binding) rather than clutter up the view model by creating a bunch of similar computed observables. In this case, the dependency might only happen while parsing the binding string. Really I think that it is something that we should look into for KO core. It would be nice if the call to valueAccessor() would really capture all of the dependencies, even if we can't know sooner that the binding was invalid.
from knockout-sortable.
Ryan, thanks for the detailed explanation. Very helpful.
Really I think that it is something that we should look into for KO core. It would be nice if the call to valueAccessor() would really capture all of the dependencies
This is one of the main features that I included to support independent binding evaluation. So hopefully this will get in soon.
from knockout-sortable.
@rniemeyer Works like a charm, great work!
from knockout-sortable.
@mbest didn't realize that your independent bindings work would do this properly already. It is an issue that I wrestle with frequently.
from knockout-sortable.
@rniemeyer It wasn't something that I had specifically targeted but was supported almost automatically for independent bindings. I added some minor changes now so that it's supported in the 'dependent' binding mode also.
from knockout-sortable.
Related Issues (20)
- observableArray extended with deferred: true removes items from list HOT 2
- Draggable Incorrectly calls template init/update
- Using droppable next to a sortable
- Draggable Droppable Issue
- sortable dissapears after first drop HOT 4
- knockout-sortable not re-rendering when dragging to same index
- Sortable not working with latest jquery HOT 3
- Input and textarea cannot be selected in Firefox 40
- sortable behaviour inconsistent with droppable/draggable
- Confirmation popup before aftermove is executed HOT 1
- Sortable not working after upgrading to knockout 3.5 HOT 10
- anonymous templates will break in next version of knockout HOT 3
- droppable options drop event issue
- Does not work with knockout 3.5.0 HOT 2
- Problem after upgrading ko to 3.5.1 HOT 3
- Nested sortable support
- knockout-sortable drag and drop not working in Windows touch devices
- Get an error after clean data HOT 3
- JS error introduced by v1.2.1 "Fixed draggable and droppable disposal" HOT 1
- disableSelection on sortable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knockout-sortable.