Comments (5)
@ferdicus Most of the issues I have had in the past are related to one module asking for a specific version of a module and then others not ready to be upgraded (because let's face it, most people have a lot of modules in their project) and RN usually has a lot of breaking changes, specially in 0.59.
When creating a module I don't think we should be thinking about people only hacing Mapbox in their project...it is a whole ecosystem. So supporting only the latest RN version creates a lot of issues and barriers to new users. Specially when Hooks is a new pattern and does not add any specific feature to the framework. aka it is not needed. I do love hooks tho, and I'd love to use them, I just don't feel a lot of modules are ready for 0.59.
Also, I am not saying people should not update. What I am saying is that if we use a feature that is only available in 0.59 then everyone needs to use that one.
from maps.
Aren't we forcing people to update their React/RN packages if we do this? Hooks are in v16.8.0 so people are forced to update to RN 0.59. I am not sure a lot of packages are ready to run on 0.59. Maybe we should wait a few RN releases so every package has time to catch up.
from maps.
Just my 2 cents
@sfratini: I don't know about this argument. You're basically validating people not updating their dependencies - which people should be doing.
Everyone else should be using previous versions of this lib,
just like they apparently do with their other dependencies.
from maps.
We should update all of our components to move away from class based components to function based and they should use the React hooks API
You could pave this long road without forcing the RN upgrade using Recompose, React Hooks "parent" which still can do much than Hooks.
(I am replacing all class based components in all my active projects :) )
from maps.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from maps.
Related Issues (20)
- [Bug]: Layers drawn incorrectly at certain zoom levels HOT 2
- [Bug]: @rnmapbox/maps 10.1.3 not working with react native v0.64.4 in android HOT 3
- Mapbox V11: MapboxMobileEvents uninstalls when following documentation for V11 setup. Anyone else facing this? HOT 2
- Build Failed. Found errors in the project; aborting build. HOT 2
- [Bug]: HOT 2
- iOS v11 setting $RNMapboxMapsVersion HOT 1
- [Bug]: Mapbox error Failed to find RNMBXPointAnntoation. [RN Expo] HOT 3
- [Bug]: Offline map downloading the tiles ,not showing the proper map and deleting the offlinemap not deleting from the app storage HOT 1
- [Bug]: iOS: localizeLabels not adopted when changing map style HOT 1
- [Bug]: queryRenderedFeaturesInRect with empty array HOT 1
- Fresh project, can't build android... HOT 2
- [Bug]: images not being stretched? HOT 4
- [Bug]: Console Warning: MapIdle Not Supported During Jest Testing HOT 1
- Could not find com.mapbox.maps:android:10.16.2 HOT 1
- [Bug]: getVisibleBounds return wrong coordinate when rotating HOT 2
- [Bug]: PointAnnotation need to click 2x same item to open HOT 3
- [Bug]: Local Filesystem raster tiles HOT 1
- [Bug]: requestDisallowInterceptTouchEvent broken HOT 1
- [Bug]: Camera component bounds prop not working properly HOT 2
- [Bug]: Camera component bounds prop not working properly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maps.