Giter Site home page Giter Site logo

Comments (5)

sfratini avatar sfratini commented on May 8, 2024 2

@ferdicus Most of the issues I have had in the past are related to one module asking for a specific version of a module and then others not ready to be upgraded (because let's face it, most people have a lot of modules in their project) and RN usually has a lot of breaking changes, specially in 0.59.

When creating a module I don't think we should be thinking about people only hacing Mapbox in their project...it is a whole ecosystem. So supporting only the latest RN version creates a lot of issues and barriers to new users. Specially when Hooks is a new pattern and does not add any specific feature to the framework. aka it is not needed. I do love hooks tho, and I'd love to use them, I just don't feel a lot of modules are ready for 0.59.

Also, I am not saying people should not update. What I am saying is that if we use a feature that is only available in 0.59 then everyone needs to use that one.

from maps.

sfratini avatar sfratini commented on May 8, 2024

Aren't we forcing people to update their React/RN packages if we do this? Hooks are in v16.8.0 so people are forced to update to RN 0.59. I am not sure a lot of packages are ready to run on 0.59. Maybe we should wait a few RN releases so every package has time to catch up.

facebook/react-native#21967

from maps.

ferdicus avatar ferdicus commented on May 8, 2024

Just my 2 cents

@sfratini: I don't know about this argument. You're basically validating people not updating their dependencies - which people should be doing.

Everyone else should be using previous versions of this lib,
just like they apparently do with their other dependencies.

from maps.

slaivyn avatar slaivyn commented on May 8, 2024

We should update all of our components to move away from class based components to function based and they should use the React hooks API

You could pave this long road without forcing the RN upgrade using Recompose, React Hooks "parent" which still can do much than Hooks.
(I am replacing all class based components in all my active projects :) )

from maps.

stale avatar stale commented on May 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from maps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.