Comments (5)
The version of material-ui/core was updated 15 days ago (snyk PR) to 4.11.3 and it's at 4.11.0 everywhere else I've looked. This could be the culprit. I'll try and repro your issue tomorrow and see if we can get to the bottom of it.
from backstage-plugin-argo-cd.
The version of material-ui/core was updated 15 days ago (snyk PR) to 4.11.3 and it's at 4.11.0 everywhere else I've looked. This could be the culprit. I'll try and repro your issue tomorrow and see if we can get to the bottom of it.
Yep, I'm thinking this may be the culprit. Going to test it out in the morning and post an update.
from backstage-plugin-argo-cd.
Hey team. Update from my side, I've confirmed it's an issue with the material-ui/core version. ArgoCD plugin was on v4.11.3 whilst the rest of the plugins and core Backstage imports I were using were on 4.11.0. I'm happy to close this as the resolution will either updating the other packages or using v3.0.0 of this plugin until the other components have upgraded material-ui/core.
from backstage-plugin-argo-cd.
Thanks @anderoo. I suppose from our side we'll need a process for managing the non-backstage package versions across our plugins (backstage-cli versions
only covers backstage packages, naturally). In this case, if there's no vulnerability with 4.11.0 I think we might downgrade here to bring this plugin in line with the rest and with the upstream (the mui version doesn't appear to change often upstream).
from backstage-plugin-argo-cd.
I have tested it at its previous value, "@material-ui/core": "^4.9.1", and it works as expected, I will submit a PR for it
from backstage-plugin-argo-cd.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backstage-plugin-argo-cd.