Unexpected styling of ArgoCDDetailsWidget

[roadiehq]

Unexpected styling of ArgoCDDetailsWidget

[iain-b]

The version of material-ui/core was updated 15 days ago (snyk PR) to 4.11.3 and it's at 4.11.0 everywhere else I've looked. This could be the culprit. I'll try and repro your issue tomorrow and see if we can get to the bottom of it.

[anderoo]

The version of material-ui/core was updated 15 days ago (snyk PR) to 4.11.3 and it's at 4.11.0 everywhere else I've looked. This could be the culprit. I'll try and repro your issue tomorrow and see if we can get to the bottom of it.

Yep, I'm thinking this may be the culprit. Going to test it out in the morning and post an update.

[anderoo]

Hey team. Update from my side, I've confirmed it's an issue with the material-ui/core version. ArgoCD plugin was on v4.11.3 whilst the rest of the plugins and core Backstage imports I were using were on 4.11.0. I'm happy to close this as the resolution will either updating the other packages or using v3.0.0 of this plugin until the other components have upgraded material-ui/core.

[iain-b]

Thanks @anderoo. I suppose from our side we'll need a process for managing the non-backstage package versions across our plugins (backstage-cli versions only covers backstage packages, naturally). In this case, if there's no vulnerability with 4.11.0 I think we might downgrade here to bring this plugin in line with the rest and with the upstream (the mui version doesn't appear to change often upstream).

[padraigobrien]

I have tested it at its previous value, "@material-ui/core": "^4.9.1", and it works as expected, I will submit a PR for it