Github PR plugin does not seem to work for private repo

[roadiehq]

Github PR plugin does not seem to work for private repo

[ArchanaSwamy]

@andrewthauer / @dtuite You guys are amazing with your support system. It finally worked. Thank you. I had to create an OAthAPP at org admin level and the rest was magic.

[ArchanaSwamy]

@dtuite - I just noticed a user had reported this a few months back. #5 . Does the temporary fix work?

[dtuite]

Thanks @ArchanaSwamy. We will look into this and track down the problem.

[lewtakm]

Plugin should support private repositories. I just performed a test with my private repo and it works correctly.
404 error maybe caused by wrong github.com/project-slug
For example:

I made a type there and used recipess instead of recipes.
Are you sure that project-slug is set up correctly? If yes, please let me know and I will investigate this a bit more.

[ArchanaSwamy]

My project is github.com/project-slug: org/repo. I can see the API request hitting the correct end point. Couple of things to mention here.

I have used Github SSO which connects properly via the client id and secret. However we log into backstage as a guest and not user basis. Could this be a reason? I see an authorization token injected. I don't know where is it picking this and it seems it is session based.

Do I need to add anything in the packages/app/src/api.ts as we are using a standalone app and not a clone of backstage repo.
`
import { createApiFactory } from '@backstage/core';
import { GithubPullRequestsClient, githubPullRequestsApiRef } from '@roadiehq/backstage-plugin-github-pull-requests';

export const apis = [
createApiFactory(githubPullRequestsApiRef, new GithubPullRequestsClient()),
];
`

[ArchanaSwamy]

Another point. I didn't explicitly mention Github enterprise setting in the app-config as we are not using any graphql in github. The Github OathApp has been created at my user account level and not org admin level.

[andrewthauer]

@ArchanaSwamy - Out of curiosity did you create the OAuth app under the org that owns the private repos? I'm not sure it works otherwise. For instance if you create the OAuth app under a member of the org you'll be able to login, but still not have access to private repos even though your login user does.

[ArchanaSwamy]

@andrewthauer No I created the OAth app under my user account.Can we actually create OathApp under an org? I can't seem to find an option to do as it defaults to my Settings->Developer settings->OathAPp.

[andrewthauer]

@andrewthauer No I created the OAth app under my user account.Can we actually create OathApp under an org? I can't seem to find an option to do as it defaults to my Settings->Developer settings->OathAPp.

I believe you would need to be an org admin to do this.

[ArchanaSwamy]

@andrewthauer ok so if I got it right, you are recommending I create a OathApp via org admin and then pass the credentials. Does this allow the private repo to be accessed ?

[andrewthauer]

@ArchanaSwamy - Correct. It should work then.

[andrewthauer]

@dtuite / @lewtakm - It might make sense to document this somewhere? I'm thinking this probably makes sense to have documented as part of the main backstage repo as general steps (considering the GH OAuth setup is not documented anywhere in backstage that I'm aware of). Maybe somewhere in https://backstage.io/docs/auth/. Then this repo could possibly point there.

[dtuite]

Awesome @andrewthauer. I didn't know about this either. I'll open an issue on backstage/backstage now to get this documented.