Giter Site home page Giter Site logo

Comments (11)

robb0wen avatar robb0wen commented on June 9, 2024 2

Thanks! I've given this a lot of though and, whilst I was considering reducing the version number to allow it to be installed on older editions, I've decided it's best to leave it as-is. 1.33.0 is the minimum install version.

Until VS Code adds support for custom CSS natively, adding the glow to the theme is experimental (read: a bit of a hack). Locking it at 1.33.0 I at least know it's possible to get it working with the versions of VS Code, and the Custom CSS and JS extension at the time of the original launch. The installation is already messy and I don't want to muddy it further, or risk editor instability, by introducing older versions into the mix.

from synthwave-vscode.

jarcane avatar jarcane commented on June 9, 2024 1

Also not compatible with 1.31.1.

from synthwave-vscode.

robb0wen avatar robb0wen commented on June 9, 2024 1

I generated the theme with the VS code yeoman generator and it set the latest engine value in the package json to be 1.33.0 so it should work from that version and up. I'll see if I can update it to be lower.

from synthwave-vscode.

alvico avatar alvico commented on June 9, 2024 1

I've updated manually to the latest version and it works, fine, somehow I was stuck in an older version and it was refusing to update itself. Thanks for the work, and feel free to close the issue if you feel so.

from synthwave-vscode.

SolalVall avatar SolalVall commented on June 9, 2024 1

Like @robb0wen said, by default you can't install an extension when his version is greater than your vscode version.

A way to make it works for prior version maybe, is to reduce the version requirements in package.json

"engines": {
        "vscode": "^1.33.0"
},

To (for example):

"engines": {
        "vscode": "^1.20.0"
},

Tag this revision to v0.0.1 for example.

Then it will be possible to download a prior version of an extension by adding the specific tag in the URL:
https://ms-vscode.gallery.vsassets.io/_apis/public/gallery/publisher/{ owner }/extension/{ extension_name }/{ version }/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

In my example it will look like this:
https://ms-vscode.gallery.vsassets.io/_apis/public/gallery/publisher/RobbOwen/extension/synthwave-vscode/0.0.1/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

Once downloaded the user can manually add the extension to vsocde:
https://vscode-docs.readthedocs.io/en/stable/extensions/install-extension/

from synthwave-vscode.

mdvorscak avatar mdvorscak commented on June 9, 2024

I get the error: Cannot read property 'id' of undefined when trying to set the theme

from synthwave-vscode.

fernandezpablo85 avatar fernandezpablo85 commented on June 9, 2024

Also not compatible with 1.32.3

from synthwave-vscode.

LiamRR avatar LiamRR commented on June 9, 2024

Also not compatible with Version 1.23.1 (1.23.1) on macOS Mojave 10.14.4

Error:
Unable to install 'RobbOwen.synthwave-vscode'; there is no available version compatible with VS Code '1.23.1'.

from synthwave-vscode.

f4ww4z avatar f4ww4z commented on June 9, 2024

Also not working with version 1.33.1.

from synthwave-vscode.

mdvorscak avatar mdvorscak commented on June 9, 2024

Uninstalling and reinstalling seems to have fixed the issue, thanks!

from synthwave-vscode.

erickbRodrigues avatar erickbRodrigues commented on June 9, 2024

Isnt it possible to add 1.31.0 without the glow ?

I really loved the theme, but I work on a HUGE bank in brazil and we can't update our apps without our infrastructure approvals.

:(

from synthwave-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.