Close order did not work as expected

[oldlore]

Close order did not work as expected

[tgibson11]

Disregard my previous comment (I'm going to delete it, but wanted to explain)...closer inspection of the logs shows that 2 contract orders were created because I ran the method for creating roll orders manually, then stack handler ran it a second time.

It would be nice if this situation was recognized and handled better (by not creating duplicate contract orders)...but ultimately it could be considered user error, since that method seems to be intended to run only once per day.

Edit:
So...deleting my previous comment was probably a mistake because now there's no context for this one. So...

1. My issue was related to Close roll status and I thought it might possibly be related to OP's issue.
2. Turns out it was not.
3. My reference to "user error" above refers to my issue, not the OP's.

[oldlore]

So I tried generating a force roll order using interactive order stack and it also failed. Did some digging with elementary python skills and I think I localized the bug to roll_orders.py function in line 98:

    def check_if_positions_require_order_generation(self, instrument_code: str) -> bool:
        position_in_priced = get_position_in_priced(
            data=self.data, instrument_code=instrument_code
        )
        if position_in_priced == 0:
            ## no need to roll
            return False

If you have a position in the instrument this function always returns None, which causes line 79 to return True and the process to create and add orders to the stack fails.

roll_orders_required_from_positions = self.check_if_positions_require_order_generation(instrument_code)
        if not roll_orders_required_from_positions:
            ## if we don't exit here will get errors even it we're not rolling
            return False

LOL which is exactly what tgibson fixed in #1245
Oops!

[robcarver17]

So is this now fixed??

[oldlore]

I have a close order today for GAS_US_mini. Stack handler did create a contract order but trade isn't due to happen for a couple hours, so I will update if it goes through. On the other hand, I had 2 force rolls as well. Stack handler created instrument/contract orders as expected but nothing further is happening. See #1249

EDIT: The close order went through okay. So I think this issue is fixed.