New Changes Ready for Pull Request

[robert7]

New Changes Ready for Pull Request

[robert7]

Hi.

I updated the source code and added this feature, on a new branch called "f9Everywhere".

Ok. great!

You don't need push rights. It works like this:

1. fork mine repository.
2. Then push the feature branch in your fork repo.
3. Then from there you can open the pull request. This is standard way how github works. Let me know, if it doesn't work..

E.g. I also have no push rights in the upstream repository and I were able to open pull request (which sadly no one is able to merge).

[MRC01]

Great. I just submitted the pull request.

…

On 09/15/2018 11:49 PM, Robert Spiegel wrote: Hi. I updated the source code and added this feature, on a new branch called "f9Everywhere". Ok. great! You don't need push rights. It works like this: 1. fork mine repository. 2. Then push the feature branch in your fork repo. 3. Then from there you can open the pull request. This is standard way how github works. Let me know, if it doesn't work.. E.g. I also have no push rights in the upstream repository and I were able to open pull request (which sadly no one is able to merge). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEZyB8tAoYiUnraWzPjhzYg5SSkA6G2ks5ubfSSgaJpZM4Wqnlm>.

[robert7]

thx; I'll look at it

[robert7]

PR merged. Thanks.

Note that if you want to compile now, there is slight change in the project (I described it in the main README). The Tidy library now needs to be compiled to a fixed path "/opt/tidy56" (you can either compile it there yourself or install "html-tidy56" from my new PPA.
The app can also now be installed from PPA, but its not yet 100% finished (but already pretty close).