Dealing with | symbol

[ymmark0]

Dealing with | symbol

[robinst]

Hey! I'm definitely interested in detecting www. style links. It could be another LinkType so that detection can be enabled/disabled using LinkExtractor.Builder#linkTypes. If you could do that as a PR, that would be great :).

As for recognizing | as a terminating character, that would be at odds with the existing logic. Currently, the only thing that causes a definite end of a URL is whitespace, and then we backtrack from there.

So I would recommend splitting the |xyz from the URL in a step after link detection, in your own code.

[ymmark0]

Hey Robin,
Ok, that sounds fine. The | symbol is my first priority and then I’ll get onto www.
I may have the odd question if you don’t mind?

Cheers
Mark.

On 11 Mar 2016, at 00:38, Robin Stocker [email protected] wrote:

Hey! I'm definitely interested in detecting www. style links. It could be another LinkType so that detection can be enabled/disabled using LinkExtractor.Builder#linkTypes. If you could do that as a PR, that would be great :).

As for recognizing | as a terminating character, that would be at odds with the existing logic. Currently, the only thing that causes a definite end of a URL is whitespace, and then we backtrack from there.

So I would recommend splitting the |xyz from the URL in a step after link detection, in your own code.

—
Reply to this email directly or view it on GitHub #6 (comment).

[ymmark0]

Hey Robin
When you say link detection, do you mean link extraction?

Cheers
Mark.

On 11 Mar 2016, at 00:38, Robin Stocker [email protected] wrote:

Hey! I'm definitely interested in detecting www. style links. It could be another LinkType so that detection can be enabled/disabled using LinkExtractor.Builder#linkTypes. If you could do that as a PR, that would be great :).

As for recognizing | as a terminating character, that would be at odds with the existing logic. Currently, the only thing that causes a definite end of a URL is whitespace, and then we backtrack from there.

So I would recommend splitting the |xyz from the URL in a step after link detection, in your own code.

—
Reply to this email directly or view it on GitHub #6 (comment).

[robinst]

I may have the odd question if you don’t mind?

Sure :).

When you say link detection, do you mean link extraction?

Yeah, I use them interchangeably.