Filtering by multiple payment methods

[Renato1478]

Filtering by multiple payment methods

[Reckless-Satoshi]

Hey @Renato1478 . Indeed, this is a potentially useful feature.

The order book filtering only allows for one payment_method input at the moment. Several changes are needed as:

• In desktop (large screens) the same Autocomplete field as seen in the Create page is used, however, it is limited to 1 entry.
• On Mobile, it is a dropdown selection (so only 1 method allowed as well).

The filtering function, already accepts multiple payment methods:

robosats/frontend/src/utils/filterOrders.ts

Lines 18 to 28 in 3604d2f

	const filterByPayment = function (order: PublicOrder, paymentMethods: any[]): boolean {
	if (paymentMethods.length === 0) {
	return true;
	} else {
	let result = false;
	paymentMethods.forEach((method) => {
	result = result || order.payment_method.includes(method.name);
	});
	return result;
	}
	};

I am not sure using the AutocompletePayment component on the Order book controls in mobile is a great idea, as selecting from a dropdown is way easier than writing on mobile. However, on desktop, it is likely very easy to fix the AutocomplePayment component on the book controls to accept several elements on the array of methods instead of just one.

If you want to work on it, we will gladly accept this PR. We can do a small tip from the devfund for the contribution of 20K Sats for this feature. Please, keep in mind our latest developments are in branch the-federation-layer-v0.6.0, so it would be best if you work on top of its tip commit :)

[Reckless-Satoshi]

Hey @Renato1478 , yes this could work for both mobile and desktop! The only drawback is the extra two clicks needed to open and confirm the new dialog. It's hard to say, do you think those two extra clicks are worthy in order to gain the edge ability to filter by more than one payment method at once?

I think it's a good case to bring up in the telegram group and see how users feel about it. It is definitely worth to implement if most users always look for several payment methods at once.

[Renato1478]

I'm willing to work on this feature if it's considered relevant to the app.

[Renato1478]

Thanks for the reply! I'll start working on a solution asap then. Because the order book page is quite complex, I was thinking about opening a dialog after clicking in the field, smth like this:  And then, the display in both mobile and desktop could be smth like this:  With this behavior we'll have no problems with responsivity since the Selection will be in a Dialog Box and the display will be handled by '[PM1], [PM2], [n]+'. Let me know what you think @Reckless-Satoshi .

[Renato1478]

Thanks for the reply! In respect on the extra clicks, I just opened the PR #1172 making this possible without creating extra clicks or the average user who wants to filter by just 1 method.

[Reckless-Satoshi]

#1172 was merged!