Giter Site home page Giter Site logo

Comments (13)

DrakePork avatar DrakePork commented on August 24, 2024 1

Well I've investigated some more and its 100% CommandPanels as I tested it with only this plugin, but appears to be happening due to one of my panels so I'll see if I can find out which one it is and why its causing PlayerInteractEvent to go crazy.

from commandpanels.

rockyhawk64 avatar rockyhawk64 commented on August 24, 2024

Try following these steps: https://aikar.co/2018/07/02/tuning-the-jvm-g1gc-garbage-collector-flags-for-minecraft/

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

Nupe CommandPanels still taking up a lot of tick, especially through PlayerInteractEvent
https://timings.aikar.co/?id=d5ef3568b5a04230af1a2da08679224d#plugins

from commandpanels.

rockyhawk64 avatar rockyhawk64 commented on August 24, 2024

Can you send your CommandPanels plugin folder? I have had no issues with paper using 1.16 to this extent, usually, there is some external factor or something in the plugins folder that causes this.
EDIT: If you could also list the other plugins you use that would be great.

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

Plugin List

CommandPanels Folder

from commandpanels.

fireFerry avatar fireFerry commented on August 24, 2024

Just a quick note, Command Panels is not compatible with Plugman, you need to use /cpr or restart your server.

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

Yeah, I only use plugman restart on my custom coded plugins.

from commandpanels.

rockyhawk64 avatar rockyhawk64 commented on August 24, 2024

https://www.spigotmc.org/threads/too-many-plugins-is-bad.904/
Should have a read of this, CommandPanels could be lagging as a result of this.

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

Well I've tracked it down to these two files Files

Dont really know why they're causing PlayerInteractEvent to go crazy but yeah.

Edit: Of course as soon as I try it with more plugins another file decides it doesnt want to play nice anymore. I'm at this point just gonna guess the reason behind the lag is the files being too long

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

The other problem is that those two panels up there are not released/rarely used, and when I was testing earlier with only CommandPanels I was literally just having all the panels on and then flying around and breaking blocks which caused the PlayerInteractEvent to happen, and never actually opened a GUI.

from commandpanels.

rockyhawk64 avatar rockyhawk64 commented on August 24, 2024

Yeah, the PlayerInteractEvent is called when the player interacts, aka right-clicking blocks for an example.

This is the code for the event here too:

public void onPlayerUse(PlayerInteractEvent e){

Which shows it isn't that long.. (line 283-322)

Either way, I will add some updates that will disable code that isn't required, as that code for you would not be required because it is only to open the panel via Hotbar.

from commandpanels.

rockyhawk64 avatar rockyhawk64 commented on August 24, 2024

I have added some optimization for future updates. The PlayerInteractEvent that seems to be lagging will not run if it doesn't need to (which is didn't in your case).
There seems to still be higher timing, despite it only running almost nothing. Very strange, not sure why it would be spitting that out, either way, it will run better.

from commandpanels.

DrakePork avatar DrakePork commented on August 24, 2024

What I meant by long was those panel files being 1000+ lines long, not the event, but yeah that latest update seems to have fixed it. Thanks.

from commandpanels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.