Comments (9)
The main reason was that 3.10 was the newest version at the time we started developing rocPRIM. We didn't see any reason to use an old tool, when there is a new one, and installing new CMake is very easy. Additionally, we got some problems with CMake 3.5 and 3.8 (something worked for one, but not for the other) during rocRAND development.
To be honest, I don't know why it does not work for you. We have about 5-7 different machines with cmake 3.10 and ROCm + docker for CI, and we've never had a problem with finding ROCm package. Also failure in finding ROCm package should not cause build failure, because in such cases required rocm-cmake project is automatically downloaded.
from rocprim.
This is my output using cmake 3.5.1
cmake ..
-- Found HIP: /opt/rocm (found version "1.5.18081")
-- The CXX compiler identification is Clang 6.0.0
-- Check for working CXX compiler: /opt/rocm/bin/hcc
-- Check for working CXX compiler: /opt/rocm/bin/hcc -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting build type to 'Release' as none was specified.
-- Found Git: /usr/bin/git (found version "2.7.4")
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Found GTest: /usr/local/lib/libgtest.a
-- ******** Summary ********
-- General:
-- System : Linux
-- HIP ROOT : /opt/rocm
-- C++ compiler : /opt/rocm/bin/hcc
-- C++ compiler version : 6.0.0
-- CXX flags :
-- Build type : Release
-- Install prefix : /opt/rocm
--
-- BUILD_TEST : ON
-- BUILD_BENCHMARK : OFF
-- BUILD_EXAMPLE : OFF
-- Configuring done
-- Generating done
-- Build files have been written to: ./build
and this using cmake 3.11.0
/opt/cmake-3.11.0/bin/cmake ..
-- Found HIP: /opt/rocm (found version "1.5.18081")
-- The CXX compiler identification is Clang 6.0.0
-- Check for working CXX compiler: /opt/rocm/bin/hcc
-- Check for working CXX compiler: /opt/rocm/bin/hcc -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting build type to 'Release' as none was specified.
-- Found Git: /usr/bin/git (found version "2.7.4")
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Found GTest: /usr/local/lib/libgtest.a
CMake Error at cmake/Dependencies.cmake:138 (find_package):
Could not find a package configuration file provided by "ROCM" with any of
the following names:
ROCMConfig.cmake
rocm-config.cmake
Add the installation prefix of "ROCM" to CMAKE_PREFIX_PATH or set
"ROCM_DIR" to a directory containing one of the above files. If "ROCM"
provides a separate development package or SDK, be sure it has been
installed.
Call Stack (most recent call first):
CMakeLists.txt:63 (include)
-- Configuring incomplete, errors occurred!
See also "./build/CMakeFiles/CMakeOutput.log".
See also "./build/CMakeFiles/CMakeError.log".
from rocprim.
I've just tested 3.11.1 on CUDA machine (where rocm-cmake is always downloaded) and it works ok. Checking ROCm platform now.
from rocprim.
It works on ROCm platform and a docker-based CI too. Do you have rocm-cmake
package installed? Is there rocm-cmake-master
folder in your build
folder after you run cmake script?
from rocprim.
It's also possible that somehow download command or zip extraction fail for you, but I assume it would fail on 3.5 too.
from rocprim.
I am going to have look at that. Seems download worked, but it did not unzip the file, build directory only holds the .zip file.
cmake 3.5 works fine (also downloading and unzip).
from rocprim.
Hmm.. I really don't know why unziping works on 3.5 but not on 3.11 for you.
from rocprim.
If there is no show stopper, I think we should move back to cmake 3.5, also because it is the standard available version with ubuntu 16.04.
from rocprim.
There were problems with handling CUDA in cmake 3.5.1, but they're fixed for the final release (ETA halfway June). When you're only working with AMD devices you can safely use cmake 3.5.1.
from rocprim.
Related Issues (20)
- Invalid use of inline assembly for GFX1010 target HOT 14
- Compiler Build issue HOT 1
- ROCm 3.9.1 fails to compile benchmark_warp_scan HOT 2
- error: reference to __host__ function 'inclusive_scan<rocprim::default_config, double *, double *, thrust::plus<double>>' in __host__ __device__ function HOT 2
- Ignoring return value warning HOT 2
- error: invalid operands to binary expression HOT 6
- Please enable two factor authentication in your github account
- Alternative documentation HOT 2
- error: no matching function for call to 'ceiling_div' HOT 2
- Add support for NAVI22 and NAVI23 i.e. gfx1031 and gfx1032 HOT 1
- rocPRIM reduction (block_reduce_int) issue HOT 2
- Follow the example of rocPRIM custom types example but compile failed. HOT 2
- rocPRIM on NAVI22 = gfx1031 only one test fails - can we fix this? HOT 6
- rocPRIM -- rocThrust dependency: error: no member named 'init_offset_scan_state_kernel' in rocprim::detail HOT 2
- rocPRIM 5.4.3 failed device_adjacent_difference on gfx906 HOT 4
- rocPRIM selects wrong code paths for warp reductions and scas on gfx1036 HOT 3
- Page fault during `rocprim::select` for no obvious reason. HOT 2
- `rocprim::block_load` fails to instantiate HOT 8
- first installation failed
- Failing tests with libstdc++ assertions due to unsigned overflow HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocprim.