Giter Site home page Giter Site logo

Comments (11)

doctorcolinsmith avatar doctorcolinsmith commented on July 29, 2024

@mfep Please take a look at this.

from rocthrust.

doctorcolinsmith avatar doctorcolinsmith commented on July 29, 2024

Also, note that the 6700XT is not officially supported in the ROCm stack at this time.

from rocthrust.

klausbu avatar klausbu commented on July 29, 2024

Has this issue been resolved?

from rocthrust.

littlewu2508 avatar littlewu2508 commented on July 29, 2024

from rocthrust.

littlewu2508 avatar littlewu2508 commented on July 29, 2024

For rocThrust-5.1.3 (hip-5.3.3, clang-15.0.7), tests all passed on 6700XT.

There are issues about compiling rocThrust-5.3.3. I'll report that in another issue.

from rocthrust.

klausbu avatar klausbu commented on July 29, 2024

There's the other open question: How can I compile rocThrust-5.1.3 with my local, modified version of rocPRIM supporting gfx1031 instead of triggering the download of the unmodified version as defined in the install script?

from rocthrust.

littlewu2508 avatar littlewu2508 commented on July 29, 2024

There's the other open question: How can I compile rocThrust-5.1.3 with my local, modified version of rocPRIM supporting gfx1031 instead of triggering the download of the unmodified version as defined in the install script?

I think if your rocprim-config.cmake is in default search locations (like /usr/lib64/cmake) then find_package will automatically choose the local installation.

Actually I packaged rocThrust and rocPRIM in gentoo, applying some patches to enable gfx1031 and deleting codes about downloading dependencies.

from rocthrust.

Snektron avatar Snektron commented on July 29, 2024

See #268

from rocthrust.

klausbu avatar klausbu commented on July 29, 2024

Where can I find the changes/patches you applied to rocThrust and rocPRIM for the gentoo implementation?

from rocthrust.

littlewu2508 avatar littlewu2508 commented on July 29, 2024

Where can I find the changes/patches you applied to rocThrust and rocPRIM for the gentoo implementation?

You can check the ebuilds out at rocPRIM-5.1.3.ebuild and rocThrust-5.1.3.ebuild, where I applied some sed commands to remove downloading external dependencies, non-FHS install scripts (which shouldn't be a matter now because ROCm now supports turning off the backward compatible, non-FHS install).

As I remember no dedicated patches is applied for gfx1031. The key is to set -DAMDGPU_TARGETS=gfx1031 for cmake configuration.

from rocthrust.

klausbu avatar klausbu commented on July 29, 2024

Setting the target works, my problem is a compile error related to rocPRIM but the rocPRIM installation and tests went well:

... In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/detail/scan.inl:29: In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/system/detail/adl/scan_by_key.h:44: In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/system/hip/detail/scan_by_key.h:36: In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/system/hip/execution_policy.h:81: /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/system/hip/detail/set_operations.h:956:61: error: no member named 'init_offset_scan_state_kernel' in namespace 'rocprim::detail'; did you mean 'init_lookback_scan_state_kernel'? hipLaunchKernelGGL(HIP_KERNEL_NAME(rocprim::detail::init_offset_scan_state_kernel), ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ init_lookback_scan_state_kernel /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_runtime.h:199:30: note: expanded from macro 'HIP_KERNEL_NAME' #define HIP_KERNEL_NAME(...) __VA_ARGS__ ^~~~~~~~~~~ /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_runtime.h:251:74: note: expanded from macro 'hipLaunchKernelGGL' #define hipLaunchKernelGGL(kernelName, ...) hipLaunchKernelGGLInternal((kernelName), __VA_ARGS__) ^~~~~~~~~~ /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_runtime.h:248:9: note: expanded from macro 'hipLaunchKernelGGLInternal' kernelName<<<(numBlocks), (numThreads), (memPerBlock), (streamId)>>>(__VA_ARGS__); \ ^~~~~~~~~~ /opt/rocm-5.4.0/include/rocprim/device/detail/device_scan_common.hpp:76:60: note: 'init_lookback_scan_state_kernel' declared here __launch_bounds__(ROCPRIM_DEFAULT_MAX_BLOCK_SIZE) void init_lookback_scan_state_kernel( ^ In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/test/test_zip_iterator.cpp:18: In file included from /home/klaus/Programme/rocalution_install/rocThrust-rocm-5.1.3/thrust/../thrust/copy.h:512: ...

from rocthrust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.