CMake dependency on rocprim missing

[rocm]

CMake dependency on rocprim missing

[saadrahim]

Hi David,

Are you a first time user of rocThrust? I want to check if this issue appeared in the recent release or has existed for a while.

I believe the rocthrust-targets.cmake file is missing some INTERFACE links. I will look at fixing this issue.

Best Regards,
Saad

[davidrohr]

Hi @saadrahim : It is the first time I used it.

Btw, In the meantime, I have also found that in the example you suggest to find both rocprim and rocthrust: https://github.com/ROCmSoftwarePlatform/rocThrust/blob/master/README.md#using-rocthrust-in-a-project
But to me, this is not intuitive. If rocthrust depends on rocprim, it should automatically detect it and add the dependency.

[saadrahim]

I apologize for the problem. There was a work around introduced for a particular high profile project that broke the cmake targets. I will have a better solution in place for the rocm-2.8 or 2.9 release (late August or September). It is too late for the 2.7 release candidate.

[saadrahim]

Quick update, this fix hasn't made it to for the 2.8 or 2.9 release. I am aiming for 2.10.

[saadrahim]

@neon60 Only thing left with this issue is to add the roc::rocthrust namespace.

[neon60]

#95

[saadrahim]

Will add find_package as the default mechanism to use rocPRIM.