Comments (8)
fixed and new version 1.5.1 published and available on nuget ;)
from yeelightapi.
Hi, can you provide a code sample to help me reproduce the problem ?
from yeelightapi.
You can recreate it in the tests by passing null as smooth parameter in methods:
SetPower, TurnOff, TurnOn, SetBrightness, SetColorTemperature, SetRGBColor, SetHSVColor. Output https://pastebin.com/EMciJfmW
The tests are a little wrong though, because first you tests without smooth param, and then with smooth param, though not all applicable methods are passed the smooth param, so this also needs fixing. Also, tests show that everything is fine although half of the methods fail. And also for some reason my Yeelight is treated as BackgroundLight, although none of the methods work.
from yeelightapi.
I can't reproduce the problem ... but I don't have the same devices as you to perform my tests (I only have Yeelight V1 RGB)
There could be a firmware compatibility issue with the smooth parameter, Yeelight expects 2 parameters : "smooth|sudden" and a duration. When no duration is expected the second parameter used to be ignored in V1, but I suspect in V2 it must be an integer in order to work.
I've made a possible fix in "tests-for-v2-bulbs" branch, since I can't test it by myself, can you test it and give me your feedback ?
from yeelightapi.
The tests are a little wrong though, because first you tests without smooth param, and then with smooth param, though not all applicable methods are passed the smooth param, so this also needs fixing. Also, tests show that everything is fine although half of the methods fail. And also for some reason my Yeelight is treated as BackgroundLight, although none of the methods work.
I agree, theses tests are just a quick way for me test all the methods with most common parameters. It cannot be trusted for industrial or unit testing
from yeelightapi.
from yeelightapi.
Works like a charm
from yeelightapi.
Great, I will publish new nuget version quickly.
This will be a great opportunity to test my new azure devops pipelines 😁
from yeelightapi.
Related Issues (20)
- Event that notify a light is discovered HOT 2
- [BUG] HOT 16
- [BUG] HOT 1
- Question: is there a way to set a property? HOT 2
- [ENHANCEMENT] use IAsyncEnumerable to provide a more modern way to iterate devices found by DeviceLocator HOT 1
- Unable to detect Mi LED Smart Bulb[BUG] HOT 2
- Call to DeviceLocator.Discover() in a Xamarin Android project does not return any devices HOT 9
- [BUG] AdjustBright doesn't allow negative values
- [QUESTION] Is it possible to connect to the Yeelight device and send some commands from the device/application that is NOT in the same LAN? HOT 2
- [BUG] LED Ceiling Light brightness always returns 1 in moonlight mode HOT 2
- [SOLVED] Connect issue HOT 1
- [BUG] DeviceLocator throwing InvalidOperationException HOT 13
- Q: Support for music mode? HOT 11
- [Feature-request][Question] HOT 1
- [BUG] DeviceGroup.StartMusicMode() won't work for multiple devices HOT 6
- How it work? HOT 2
- Only works once HOT 1
- DeviceLocator.UseAllAvailableMulticastAddresses not returning all devices in v1.10.2. HOT 9
- [BUG] HOT 4
- [QUESTION] Should I create new tcp connection on every http request or persist an exist one ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yeelightapi.