[BUG] Performing actios without smooth transitio doels not work

[Dainius14]

[BUG] Performing actios without smooth transitio doels not work

[roddone]

fixed and new version 1.5.1 published and available on nuget ;)

[roddone]

Hi, can you provide a code sample to help me reproduce the problem ?

[Dainius14]

You can recreate it in the tests by passing null as smooth parameter in methods:
SetPower, TurnOff, TurnOn, SetBrightness, SetColorTemperature, SetRGBColor, SetHSVColor. Output https://pastebin.com/EMciJfmW

The tests are a little wrong though, because first you tests without smooth param, and then with smooth param, though not all applicable methods are passed the smooth param, so this also needs fixing. Also, tests show that everything is fine although half of the methods fail. And also for some reason my Yeelight is treated as BackgroundLight, although none of the methods work.

[roddone]

I can't reproduce the problem ... but I don't have the same devices as you to perform my tests (I only have Yeelight V1 RGB)
There could be a firmware compatibility issue with the smooth parameter, Yeelight expects 2 parameters : "smooth|sudden" and a duration. When no duration is expected the second parameter used to be ignored in V1, but I suspect in V2 it must be an integer in order to work.

I've made a possible fix in "tests-for-v2-bulbs" branch, since I can't test it by myself, can you test it and give me your feedback ?

[roddone]

The tests are a little wrong though, because first you tests without smooth param, and then with smooth param, though not all applicable methods are passed the smooth param, so this also needs fixing. Also, tests show that everything is fine although half of the methods fail. And also for some reason my Yeelight is treated as BackgroundLight, although none of the methods work.

I agree, theses tests are just a quick way for me test all the methods with most common parameters. It cannot be trusted for industrial or unit testing

[Dainius14]

The strange thing is that it used to work fine for more than half a year I've been using this library, something changed not so long ago (don't know exactly when, since I did not need lamps very much during the summer lol) probably after a firmware update. Alright, I'll check it when I can.

…

On Wed, 9 Oct 2019 at 11:39, Romain ODDONE ***@***.***> wrote: I can't reproduce the problem ... but I don't have the same devices as you to perform my tests (I only have Yeelight V1 RGB) There could be a firmware compatibility issue with the smooth parameter, Yeelight expects 2 parameters : "smooth|sudden" and a duration. When no duration is expected the second parameter used to be ignored in V1, but I suspect in V2 it must be an integer in order to work. I've made a possible fix in "tests-for-v2-bulbs" branch, since I can't test it by myself, can you test it and give me your feedback ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=ADUL5BVYKL2VYDCTPHOLKN3QNWKE3A5CNFSM4I6WW6B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAXDVZY#issuecomment-539900647>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADUL5BQQFDHCGRSX7PKWFATQNWKE3ANCNFSM4I6WW6BQ> .

[Dainius14]

Works like a charm

[roddone]

Great, I will publish new nuget version quickly.
This will be a great opportunity to test my new azure devops pipelines 😁