Giter Site home page Giter Site logo

Comments (5)

rodrigovimieiro avatar rodrigovimieiro commented on June 2, 2024

Hello @JeffFessler,

Thanks for posting this issue.

Do you have a code or geometry to reproduce this error?

I have tested the Branchless Distance Driven code for cone-beam geometry, but not for fan-beam. This is the implementation for cone-beam, which works fine.

from opencodes.

JeffFessler avatar JeffFessler commented on June 2, 2024

Thanks for asking.
All one has to do is change geo.DSO = 99700 to geo.DSO = 70000 so that it is more magnification and it causes an Index error.

I had to change the suffix from .m to .txt to upload the exact file.

ddbbug.txt

from opencodes.

rodrigovimieiro avatar rodrigovimieiro commented on June 2, 2024

I guess it is related with the crazy geometry I have created. When you changed the geo.DSO, for certain angles, the object was being projected outside the detector, causing the error. I am not familiar with CT geometries, so years ago I created that one (as you mentioned "almost parallel beam") just for testing.

Now, I have modified to a geometry which I think might be more realistic and maybe close to the fan-beam. I am still not sure.

Screen Shot 2022-06-23 at 3 37 06 PM

Screen Shot 2022-06-23 at 3 30 14 PM

At least it gives some results:

Screen Shot 2022-06-23 at 3 29 02 PM

This is the modified file:

ddbbug_edited.txt

See if it works for you.

from opencodes.

JeffFessler avatar JeffFessler commented on June 2, 2024

That CT detector geometry is quite realistic. However, there are two problems now.

If you look at the sinogram, you can see that there are horizontal bands every 45 or 90 degrees. It should not look like that - so there must be some bug(s) in the code.

And in practice it is usually the case that parts of the image (especially the corners) will project outside of the detector and we have to handle that carefully in the code.

If you are still working with this code and plan to fix it, please let us know.
We were converting this code to Julia and discovered the issue.
JuliaImageRecon/Sinograms.jl#9
If you fix it in Matlab, then we will translate that fix to Julia.
If you are not working with the 2D code anymore then I guess we will go back to the original papers and develop Julia code from there. Thanks.

(cc'ing @SoniaMinseoKim)

from opencodes.

rodrigovimieiro avatar rodrigovimieiro commented on June 2, 2024

I see,

I think it is somehow related to the size of the detector mapped on the X axis, see:

Screen Shot 2022-06-23 at 4 54 38 PM

So, in #L231 it makes the sonogram darker at certain angles:

sinoTmp(detInd) = sinoTmp(detInd)+(Pdk(detInd+c2)-Pdk(detInd))/deltaDetm;

There is also the fact that the mapped detector size changes depending on the detector element position. I would need to go back to the paper to see how to fix it.

Unfortunately, I am not working with 2D anymore. I will post this as a known issue. Let me know if you guys find out.

from opencodes.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.