Comments (10)
Original comment by [email protected]
on 16 Jan 2011 at 1:24
from nullpomino.
sry, it screwed up the formatting a bit (newlines):
[main] FATAL NetServer: Non-IOException throwed on server mainloop
java.util.ConcurrentModificationException at
java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:761) at
java.util.LinkedList$ListItr.remove(LinkedList.java:729) at
mu.nu.nullpo.game.net.NetServer.run(NetServer.java:1045) at
mu.nu.nullpo.game.net.NetServer.main(NetServer.java:889)
Original comment by [email protected]
on 16 Jan 2011 at 1:27
from nullpomino.
Original comment by [email protected]
on 16 Jan 2011 at 4:03
- Added labels: Priority-High
- Removed labels: Priority-Medium
from nullpomino.
Added some try-catch statement in r675.
Judging from the line-number, I think it happens when delayed-disconnection
(Used when someone tries to connect with wrong version or the IP is banned) is
used, but I'm not really sure because it doesn't happen on my local PC for some
reason.
Original comment by [email protected]
on 17 Jan 2011 at 8:54
from nullpomino.
Updated dev server to r675.
What is the behavior now, when the exception is thrown and we want to handle
the problem in the catch block? Does the entry still get removed? And do we get
a log message, so we can check?
fyi: this FATAL error happend 37 times so far, in the last two weeks
Original comment by [email protected]
on 17 Jan 2011 at 10:23
from nullpomino.
>What is the behavior now, when the exception is thrown and we want to handle
the problem in the catch block? Does the entry still get removed? And do we get
a log message, so we can check?
The try-catch block itself is just for debug log. But I also exchanged the
place of "changes.remove();" and "logout(key)" because the code of "logout"
has a lot of LinkedList manipulations. I still don't know the exact source of
the bug though.
Original comment by [email protected]
on 17 Jan 2011 at 11:10
from nullpomino.
I just analyzed the log for 675 (running for ~30h):
On more occurence of ConcurrentModificationException:
02:32:58,621 [main] INFO NetServer: Logout: *ip* (*ip*)
02:32:58,676 [main] FATAL NetServer: Non-IOException throwed on server mainloop
java.util.ConcurrentModificationException
at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:761)
at java.util.LinkedList$ListItr.next(LinkedList.java:696)
at mu.nu.nullpo.game.net.NetServer.run(NetServer.java:1048)
at mu.nu.nullpo.game.net.NetServer.main(NetServer.java:902)
and a new Exception (same source line):
02:21:39,959 [main] INFO NetServer: Socket disconnected by IOException
java.io.IOException: Connection reset by peer
at sun.nio.ch.FileDispatcher.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:21)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:237)
at sun.nio.ch.IOUtil.read(IOUtil.java:210)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:236)
at mu.nu.nullpo.game.net.NetServer.doRead(NetServer.java:1180)
at mu.nu.nullpo.game.net.NetServer.run(NetServer.java:1096)
at mu.nu.nullpo.game.net.NetServer.main(NetServer.java:902)
02:21:40,100 [main] INFO NetServer: Logout: *ip* (*ip*)
Original comment by [email protected]
on 18 Jan 2011 at 3:52
from nullpomino.
I added proper synchronization on pendingChanges and pendingData members in
r681. Should resolve this issue, will report back, if I see anymore problems in
the server log with this.
The second exception I posted in comment 7, I think is not related from what I
could see, and might even be wanted at the moment? (it is caught and just
thrown again). For a truely failed read a seperate exception is thrown though,
not qutie sure if this still needs a fix atm, but as it looks not related to
#55.
Original comment by [email protected]
on 18 Jan 2011 at 5:26
from nullpomino.
Original comment by [email protected]
on 18 Jan 2011 at 5:37
- Changed state: Fixed
from nullpomino.
added another overlooked synchronization in r690
Original comment by [email protected]
on 19 Jan 2011 at 9:46
from nullpomino.
Related Issues (20)
- Something wrong when you fail to connect. HOT 1
- Soft drop fix was never looked at again after it was removed HOT 1
- screen is black HOT 6
- GIVEUP is triggered when a Multimedia key is pressed. [LWJGL Input] HOT 12
- Team Colors HOT 3
- Hold next frame/border improvements HOT 2
- Changing rule while on netplay does not actually change rule HOT 2
- Some buttons in lobby are not visible if lobby window is too small HOT 6
- 1on1 view not applied when joining 1on1 game in progress HOT 1
- Field grid is not displayed in slick and swing version HOT 3
- Game tuning and keyconfig accessible from lobby window HOT 1
- better win count display HOT 5
- next in big mode too big
- input from pause menu goes into game
- airankstool crash on start HOT 4
- people can't get ready in netplay to work HOT 4
- garbage meter in fractional garbage sometimes temporary disappears
- setting ; and ' keys does not work in slick.bat HOT 8
- Spectators cannot see field of player who is using big pieces HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nullpomino.