Comments (6)
Huh, in the version I'm using, it matches Vim-style bindings, but in the repository code, it's flipped. I'll update it to be Vim-style to be default since that's convention and I definitely don't want to break away from that. Thanks for pointing this out!
from google-search-shortcuts.
That's strange that it seems to scroll on yours, mine jumps between the next and previous item on the latest versions of Firefox and Chrome.
On the bright side, I made a new release on Firefox inverting the keybind as well as several bug fixes with one on the setFocus
function. You could try reinstalling the latest version of the plugin (0.2.2) and see if the scrolling issue is fixed on your end.
I'm back to working on this extension now, so I'll keep this issue open as I want to let users set their own keybinds anyways.
from google-search-shortcuts.
Feel free to create a new issue for it. Thanks for finding it and taking the time to report it!
from google-search-shortcuts.
Done, just inverted the keybinds and tested it on my end. Feel free to reopen the issue if it doesn't work or if you have any more suggestions!
from google-search-shortcuts.
@RogueArt Well I tried to swap the same thing on my end locally and installed it, but it seems to scroll as opposed to go to next item, I think the setFocus
function may need to be edited as well? 🤔 Not sure why it happened tho, also the AMO version has the same inverted scroll, so a new release might be necessary.
from google-search-shortcuts.
@RogueArt I recorded this bug, however, I am unsure of whether I should post it in this issue or create a new one, which is preferable? It occurs both in the new releases, and when I web-ext build
it from the repo.
from google-search-shortcuts.
Related Issues (7)
- In releases after v0.1.0 moving search results scrolls the page as well, instead of just going to the next and previous items HOT 2
- `J` and `K` are no longer typeable in the `textarea`/`input` HOT 2
- Feature Request: Recalculate start and end of results when `More Results` is triggered HOT 1
- Allow for setting user's own keybinds for navigating up and down
- [Bug] Extension detects collapsed links not visible to the user
- [Bug] First item is not being focused sometimes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-search-shortcuts.