Comments (5)
@PascalSchumacher Good point.
OutOfMemoryError
actually would not be caught since it extendsError
. If we did something likecatch (Throwable t)
, then it would be caught.
Yes, you are right. I do not know what I was thinking. Sorry!
Thank you very much for the new release! 👍 😃
from jmail.
Thank you for the report @PascalSchumacher. You're right that this is not the expected behavior, I believe JMail should return false
in this case as this would not be considered a valid email address.
from jmail.
@PascalSchumacher please let me know if the fix in fbeecce looks good to you and I will publish a new version v1.3.3.
from jmail.
@RohanNagar Thanks for the quick fix. I always a bit nervous when I see a catch block catching Exception
because it also catches Throwables
like OutOfMemoryError
. According to the Java Doc this method only throws IllegalArgumentException
s so I believe catching that would be better. What do you think?
from jmail.
@PascalSchumacher Good point. OutOfMemoryError
actually would not be caught since it extends Error
. If we did something like catch (Throwable t)
, then it would be caught.
However since this method only throws IllegalArgumentException
it makes sense to only catch that. I've updated and released version 1.3.3, which should be available on maven central in about 10 minutes!
from jmail.
Related Issues (20)
- When validation fails, provide a reason to the caller HOT 4
- E-Mail Address Validation on https://www.rohannagar.com/jmail/ broken HOT 4
- Valid email shown as invalid HOT 8
- Question: E-Mail Address with local part containing only slashes valid? HOT 3
- Provide distinct failure reasons for each built-in rule and provide option for specifying custom failure reasons HOT 1
- Add ability to get the ASCII only version of an Email HOT 5
- Make timeout configurable for DNS MX record lookup HOT 2
- Support for configuring non-ascii characters to be invalid HOT 2
- Provide option to unquote localparts when normalising HOT 2
- Improve email address normalization HOT 1
- Add changelog file HOT 3
- Does not work for email Ids containing spaces HOT 1
- Validation reason is incorrectly called FAILED_CUSTOM_VALIDATION HOT 1
- Failure Reason incorrect HOT 1
- IPv4 validation allows non-standard digit characters HOT 3
- Question: preceding zeros in IPv4 address HOT 5
- Support no service resource record for domains that accept no mail "Null MX" HOT 2
- domain valition error while validating using mx records(JMail.validator().requireValidMXRecord();) HOT 1
- Option to validate MX record associated with email domains HOT 5
- Add documentation for all default validation rules HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jmail.