Comments (10)
Should use ActionDispatch::ExceptionWrapper.status_code_for_exception
instead of instantiating a new exception from the class name and use its name?
from lograge.
Any workarounds? I have the same issue with logger.
from lograge.
I will look into this the coming weekend. Thanks for the input @sakuro
from lograge.
I looked into it,
using ActionDispatch::ExceptionWrapper.status_code_for_exception
would work for a number of errors:
https://github.com/rails/rails/blob/1ca13b47da46247345a0d4547edc495f0cc83bf6/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb#L10-L20
But it would completely ignore the ActiveRecord::NotFound
and return a 500 for this.
Maybe there could be a combination of both approaches to catch more of the status codes.
from lograge.
AR seems that it registers AR specific exceptions to the mappings, right?
from lograge.
I expected that too after reading the code, but when executing the code with tests there is no AR specific mapping in the exception wrapper. Maybe this just gets loaded when you run rails as an "actual" instance?
from lograge.
We have the same issue in our production system. Can I help with any info? Any progress here? Thanks a lot!!!
Example stacktrace can be found here: https://gist.githubusercontent.com/andywenk/2aa6e974e637ad93bde9/raw/ab0fdf9c718f5626666252c90df3db9fbcb9e680/gistfile1.txt
from lograge.
Sorry I am currently a bit down under. We are happy about a pull request that would fix this.
from lograge.
I'm looking into this now. Hold tight.
from lograge.
@pxlpnk Ideally we'd have at least a few integration specs that load rails in its entirety to cover this end to end, but for now at least I think #134 should resolve this issue.
from lograge.
Related Issues (20)
- No logs shown in CloudWatch when lograge is enabled (Rails/ECS/Fargate) HOT 1
- Why are we striping params for redirect url?
- [Question] Project status HOT 2
- Monkey patching of Rails::Rack::Logger#call_app loses request.action_dispatch instrumentation HOT 1
- [Question] Logstash-event loaded from gh
- How to add extra log payload in action cable?
- Rails support HOT 1
- Should we demote some of our formatters to "contrib"?
- Unable to Filter ActionCable Params HOT 2
- exception cannot show on rescue_from custom handler exception HOT 1
- custom_payload is "persisted' (or per se kept) between 2 requests HOT 4
- Request: new gem release HOT 5
- Any thoughts on supporting `Turbo::StreamsChannel`? HOT 1
- Sinatra support? HOT 1
- Simpler way to remove all log subscribers. HOT 3
- Redirect in routes not handled by lograge
- Confused about what Rails logging is eliminated HOT 1
- ActionView logs not completely suppressed with Rails 7.1+
- TypeError: no implicit conversion of String into Integer when adding lograge to Rails project with Rack 3.0.9 and Puma 6.4.2 HOT 3
- Suggestion from Rails regarding better patching mechanism
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lograge.