Giter Site home page Giter Site logo

`Could not log "process_action.action_controller" event. ArgumentError: wrong number of arguments (0 for 1)` when validation error occured about lograge HOT 10 CLOSED

a-know avatar a-know commented on July 25, 2024
`Could not log "process_action.action_controller" event. ArgumentError: wrong number of arguments (0 for 1)` when validation error occured

from lograge.

Comments (10)

sakuro avatar sakuro commented on July 25, 2024

Should use ActionDispatch::ExceptionWrapper.status_code_for_exception instead of instantiating a new exception from the class name and use its name?

from lograge.

spscream avatar spscream commented on July 25, 2024

Any workarounds? I have the same issue with logger.

from lograge.

pxlpnk avatar pxlpnk commented on July 25, 2024

I will look into this the coming weekend. Thanks for the input @sakuro

from lograge.

pxlpnk avatar pxlpnk commented on July 25, 2024

I looked into it,
using ActionDispatch::ExceptionWrapper.status_code_for_exception would work for a number of errors:
https://github.com/rails/rails/blob/1ca13b47da46247345a0d4547edc495f0cc83bf6/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb#L10-L20

But it would completely ignore the ActiveRecord::NotFound and return a 500 for this.
Maybe there could be a combination of both approaches to catch more of the status codes.

from lograge.

sakuro avatar sakuro commented on July 25, 2024

AR seems that it registers AR specific exceptions to the mappings, right?

https://github.com/rails/rails/blob/1ca13b47da46247345a0d4547edc495f0cc83bf6/activerecord/lib/active_record/railtie.rb#L25

from lograge.

pxlpnk avatar pxlpnk commented on July 25, 2024

I expected that too after reading the code, but when executing the code with tests there is no AR specific mapping in the exception wrapper. Maybe this just gets loaded when you run rails as an "actual" instance?

from lograge.

andywenk avatar andywenk commented on July 25, 2024

We have the same issue in our production system. Can I help with any info? Any progress here? Thanks a lot!!!

Example stacktrace can be found here: https://gist.githubusercontent.com/andywenk/2aa6e974e637ad93bde9/raw/ab0fdf9c718f5626666252c90df3db9fbcb9e680/gistfile1.txt

from lograge.

pxlpnk avatar pxlpnk commented on July 25, 2024

Sorry I am currently a bit down under. We are happy about a pull request that would fix this.

from lograge.

benlovell avatar benlovell commented on July 25, 2024

I'm looking into this now. Hold tight.

from lograge.

benlovell avatar benlovell commented on July 25, 2024

@pxlpnk Ideally we'd have at least a few integration specs that load rails in its entirety to cover this end to end, but for now at least I think #134 should resolve this issue.

from lograge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.