Custom options not appearing for exception log lines

[nicholasmott]

Custom options not appearing for exception log lines

[nzifnab]

Having the same problem here. The problem is that append_info_to_payload is only run by Rails at the end of the action, and never gets run if there was an exception.

It can be hackishly-solved by monkey-patching actionpack/action_controller/metal/instrumentation.rb's process_action method to run append_info_to_payload before calling super, but I really don't like this solution. Is there another way to get custom values into the log hash from the controller-level?

I was even considering trying to add an event listener for the process_action.action_controller event, have it run before the one that LogRage defines, and add custom info to the payload there - but I don't think that'll work because LogRage does a clean sweep of all of those listeners and clears them out.

I'm at a bit of a loss :(

[mxrguspxrt]

From your log it seems that in somewhere in your code you try to access some models ID, but it is a nil object, and it will cause exception.

It is a Rails issue that when exception is called, #append_info_to_payload is not called. Source:

https://github.com/rails/rails/blob/ebfd97124db0cd7550dd197559343e2fda5b79d6/actionpack/lib/action_controller/metal/instrumentation.rb#L33

I am making issue and a pull request as I write this. :)

[neilberget]

Is the monkey-patching solution mentioned by @nzifnab the best work around in the meantime?

[mxrguspxrt]

He recommended that #append_info_to_payload is called before process_action, what sounds to be a bad idea and he also admitted it. It is bad, because your controller has not done it's stuff and processing result is not available at that moment.

Monkeypatching is also bad. I think you could overwrite your ApplicationController#process_action and ensure that if exception is risen you still call #append_info_to_payload

rails/rails#14903

[kommen]

FYI, this is now fixed in rails. rails/rails#17978

[benlovell]

❤️

[nicholasmott]

Awesome.