Comments (7)
Having the same problem here. The problem is that append_info_to_payload
is only run by Rails at the end of the action, and never gets run if there was an exception.
It can be hackishly-solved by monkey-patching actionpack/action_controller/metal/instrumentation.rb
's process_action
method to run append_info_to_payload
before calling super
, but I really don't like this solution. Is there another way to get custom values into the log hash from the controller-level?
I was even considering trying to add an event listener for the process_action.action_controller
event, have it run before the one that LogRage
defines, and add custom info to the payload there - but I don't think that'll work because LogRage
does a clean sweep of all of those listeners and clears them out.
I'm at a bit of a loss :(
from lograge.
From your log it seems that in somewhere in your code you try to access some models ID, but it is a nil object, and it will cause exception.
It is a Rails issue that when exception is called, #append_info_to_payload is not called. Source:
I am making issue and a pull request as I write this. :)
from lograge.
Is the monkey-patching solution mentioned by @nzifnab the best work around in the meantime?
from lograge.
He recommended that #append_info_to_payload is called before process_action, what sounds to be a bad idea and he also admitted it. It is bad, because your controller has not done it's stuff and processing result is not available at that moment.
Monkeypatching is also bad. I think you could overwrite your ApplicationController#process_action and ensure that if exception is risen you still call #append_info_to_payload
from lograge.
FYI, this is now fixed in rails. rails/rails#17978
from lograge.
❤️
from lograge.
Awesome.
from lograge.
Related Issues (20)
- No logs shown in CloudWatch when lograge is enabled (Rails/ECS/Fargate) HOT 1
- Why are we striping params for redirect url?
- [Question] Project status HOT 2
- Monkey patching of Rails::Rack::Logger#call_app loses request.action_dispatch instrumentation HOT 1
- [Question] Logstash-event loaded from gh
- How to add extra log payload in action cable?
- Rails support HOT 1
- Should we demote some of our formatters to "contrib"?
- Unable to Filter ActionCable Params HOT 2
- exception cannot show on rescue_from custom handler exception HOT 1
- custom_payload is "persisted' (or per se kept) between 2 requests HOT 4
- Request: new gem release HOT 5
- Any thoughts on supporting `Turbo::StreamsChannel`? HOT 1
- Sinatra support? HOT 1
- Simpler way to remove all log subscribers. HOT 3
- Redirect in routes not handled by lograge
- Confused about what Rails logging is eliminated HOT 1
- ActionView logs not completely suppressed with Rails 7.1+
- TypeError: no implicit conversion of String into Integer when adding lograge to Rails project with Rack 3.0.9 and Puma 6.4.2 HOT 3
- Suggestion from Rails regarding better patching mechanism
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lograge.