PATCH actions are logged as POST

[roidrage]

PATCH actions are logged as POST

[benlovell]

Good catch. Do you want to have a go at creating a patch before I do so?

[ilyakatz]

I tried to dig around in lograge code and got stuck a bit.

I couldn't figure out how the the payload is generated. So if you could point me in the right direction, i will create a patch

[stevenwilkin]

We don't have access to the current request in the notifications emitted by ActionController.

Looks like it's actually an issue with ActionController not using the correct method when sending the notification? I'll do a bit of investigating.

[stevenwilkin]

And there it is action_controller/metal/instrumentation.rb 💥

[ilyakatz]

Thanks @stevenwilkin sent a PR to Rails. I guess it doesn't make sense to tweak lograge to compensate for rails bug. Should I close this?

[stevenwilkin]

Yep, closing this seems like the thing to do @ilyakatz

[benlovell]

Thanks all ❤️

[ilyakatz]

Ok, closing.

By the way, my PR to rails was merged into master so at some point this will magically fix it self with a rails update. Until that time ... grep your logs for POST :) Thanks again, @stevenwilkin @benlovell