Giter Site home page Giter Site logo

Comments (9)

RoJoHub avatar RoJoHub commented on July 30, 2024 1

@compski @maxhis
Hi guys😀
I will fix this problem in 1.2.2.

The reason for this problem is that the 0.58 version of react native has changed. But it is now compatible.

https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md

[0.58] => Added => Android specific

  • Native Modules can now reject a promise with an additional WritableMap arg for extra properties (userInfo). See the interface defined in Promise.java for available methods. This is accessible in JavaScript as Error.userInfo. This is to match iOS's existing Error.userInfo behaviour. See PR for examples. (#20940 by @Salakar)

from react-native-ping.

maxhis avatar maxhis commented on July 30, 2024

Same here.

Changing all promise.reject(error.getCode(), error.getMessage(), null); to promise.reject(error.getCode(), error.getMessage()); in RNReactNativePingModule.java can fix the compile error.

However, got a new error:

Attempt to invoke interface method 'boolean com.facebook.react.bridge.ReadableMap.hasKey(java.lang.String)' on a null object reference
start
    RNReactNativePingModule.java:34

My workaround is replacing the line 34 if (option.hasKey(TIMEOUT_KEY)) { with if (option != null && option.hasKey(TIMEOUT_KEY)) {

from react-native-ping.

bogdandobritoiu avatar bogdandobritoiu commented on July 30, 2024

Still not fixed, checked 1.2.2. I can confirm what @maxhis did works

from react-native-ping.

RoJoHub avatar RoJoHub commented on July 30, 2024

Still not fixed, checked 1.2.2. I can confirm what @maxhis did works

Please run example for test.
It seem to ok in example

from react-native-ping.

bogdandobritoiu avatar bogdandobritoiu commented on July 30, 2024

Line 34 is still the same. Tried it on my local machine and it works as suggested by @maxhis .

if (option.hasKey(TIMEOUT_KEY)) {
with
if (option != null && option.hasKey(TIMEOUT_KEY)) {

from react-native-ping.

RoJoHub avatar RoJoHub commented on July 30, 2024

Line 34 is still the same. Tried it on my local machine and it works as suggested by @maxhis .

if (option.hasKey(TIMEOUT_KEY)) {
with
if (option != null && option.hasKey(TIMEOUT_KEY)) {

Could you please tell which version version you use?
React Native And react-native-ping

from react-native-ping.

bogdandobritoiu avatar bogdandobritoiu commented on July 30, 2024

"react-native-ping": "^1.2.2",
"react-native": "^0.59.8",

from react-native-ping.

RoJoHub avatar RoJoHub commented on July 30, 2024

Please watch package-lock.json or yarn.lock.
Check if the version of react-native-ping

image

image

from react-native-ping.

bogdandobritoiu avatar bogdandobritoiu commented on July 30, 2024

Ah yes, my lock.json had the wrong version. Sorry for the misunderstanding! Thank you for quick responses

from react-native-ping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.