Breaking API change with release of v1.4.3

[rollbar]

Breaking API change with release of v1.4.3

[cyrusradfar]

Hey @bjohnso5 and @juanantoniocid, let me look into this.

[juanantoniocid]

The New() function defined in client.go is intended to return the default implementation of a Client, but then you return a value whose type is not exported. It has broken our code (it is supposed a patch version change shouldn't break anything).

What is the purpose of New() if it is not used internally and the returned value is not exported?

[pawelsz-rb]

I think the idea was to use rollbar package directly (from rollbar.go) without instantiating the Client directly. So to me, using exported methods from rollbar.go together with exported methods from client.go does not make much sense. But if a lot of people are using Client directly and skip the stuff from rollbar.go then I am willing to revert the change and rerelease.

[pawelsz-rb]

I have reverted the change for private client and rereleased v1.4.3. Sorry about that breaking change, I guess my assumption was incorrect and it's too late to change anything now.

[pawelsz-rb]

closing for now, but please let me know if there are any problems. thank you

[juanantoniocid]

I have reverted the change for private client and rereleased v1.4.3. Sorry about that breaking change, I guess my assumption was incorrect and it's too late to change anything now.

No worries @pawelsz-rb and thanks a lot for handling it so fast!

[bjohnso5]

@pawelsz-rb I think we might need a new 1.4.4 release to actually propagate this change, when I clear my go mod cache and re-download 1.4.3, I still get the version with the unexported rollbar.client struct

[pete-woods]

That's correct, it's basically impossible to re-release a Go module version (Google's module cache prevents it)

[pawelsz-rb]

v1.4.4 released, thx!