Comments (4)
Hey @vrom911,
Thank you for looking at this 🙇♂️
The question is: is it better to change the type of the buildLogWorkerSpec to receive Natural or only change the internal of the function? Or probably you have some better ways to solve this?
What do you think about:
-
Add a new function called
buildLogWorkerSpec1
(or another name that you see makes more sense) that receives theNatural
parameter, no need to change the code. -
Modify
buildLogWorkerSpec
to do a transformation fromInt
toNatural
internally (if it is possible) inside the function. At the same time, add a deprecation pragma to this function and add to its documentation that we have deprecated this function in favor ofbuildLogWorkerSpec1
and that it will throw a runtime error if the givenInt
is not aNatural
.
Let me know your thoughts.
from haskell-capataz.
Sounds good! I will use this approach in the following PR.
from haskell-capataz.
Hey @vrom911 apologies for letting this drag, I've been changing jobs in the past week and it has been a bit crazy, I'll try to address this in the next couple of days, thank you for bearing with me
from haskell-capataz.
I see, no rush in here, @roman! Take your time 🙂
from haskell-capataz.
Related Issues (15)
- Stabalize test-suite execution
- Broken link HOT 1
- Improve documentation structure
- Replace Protolude in favor of RIO
- Add performance analysis documentation
- Create capataz-statsd project
- Add how-to guides on gitbook
- Update async upper bounds
- Allow Worker sub-routines to receive their WorkerId
- Enhance ProcessId from a type alias to a newtype
- Upgrade capataz-repo-watcher to use latest version of rio
- Make capataz compatible with ghc-8.4 HOT 1
- Support latest nightly
- Supervisor fails when it shouldn't HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haskell-capataz.