Giter Site home page Giter Site logo

Support GHC-8.6.3 about haskell-capataz HOT 4 CLOSED

vrom911 avatar vrom911 commented on May 12, 2024
Support GHC-8.6.3

from haskell-capataz.

Comments (4)

roman avatar roman commented on May 12, 2024

Hey @vrom911,

Thank you for looking at this 🙇‍♂️

The question is: is it better to change the type of the buildLogWorkerSpec to receive Natural or only change the internal of the function? Or probably you have some better ways to solve this?

What do you think about:

  • Add a new function called buildLogWorkerSpec1 (or another name that you see makes more sense) that receives the Natural parameter, no need to change the code.

  • Modify buildLogWorkerSpec to do a transformation from Int to Natural internally (if it is possible) inside the function. At the same time, add a deprecation pragma to this function and add to its documentation that we have deprecated this function in favor of buildLogWorkerSpec1 and that it will throw a runtime error if the given Int is not a Natural.

Let me know your thoughts.

from haskell-capataz.

vrom911 avatar vrom911 commented on May 12, 2024

Sounds good! I will use this approach in the following PR.

from haskell-capataz.

roman avatar roman commented on May 12, 2024

Hey @vrom911 apologies for letting this drag, I've been changing jobs in the past week and it has been a bit crazy, I'll try to address this in the next couple of days, thank you for bearing with me

from haskell-capataz.

vrom911 avatar vrom911 commented on May 12, 2024

I see, no rush in here, @roman! Take your time 🙂

from haskell-capataz.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.