small code fix needed in clipping detection

[ariel-c-verbit]

small code fix needed in clipping detection

[RookieJunChen]

First of all, thank you very much for your correction on this code! I will fix this part later.
Secondly, I don't quite understand what you said about clipping, because the code subsequently normalizes the enchanced. Will this cause a clipping problem?
enhanced = np.int16(0.8 * amp * enhanced / np.max(np.abs(enhanced)))

[ariel-c-verbit]

What causes signal values that are out of range [-1,1] is the masking itself. (cIRM amplitudes larger than 1). This is due to the model and is a common cIRM problem.

If I understand correctly, you normalize the enhanced signal to [-0.8,0.8], thus avoiding this problem.

This fixes it, but this isn't a solution that can be used in a real life live system. (for academia it is good enough though).

In a real life system (where you receive frames and not the full signal), you would need an adaptive gain control normalization or something like that. You can't just assume that you have the whole signal in advance and normalize every couple of frames to [-0.8, 0.8] since that would amplify the noise in some cases. hope this helped.

[RookieJunChen]

Thank you very much for your response, it has been quite helpful to me！