Introduction of "use Dotenv::createImmutable()" breaks servers with multiple sites

[dalepgrant]

Introduction of "use Dotenv::createImmutable()" breaks servers with multiple sites

[MWDelaney]

Hi, I cannot reproduce this issue in a testing environment. Can you tell us more about your configuration?

Here are the steps I took to reproduce:

1. Create a new Trellis instance
2. Duplicate the site directory, call it second_site
3. Update production wordpress_sites.yml and vault.yml adding a second site to each, changing the key, url, and subtree path as necessary
4. Provision production
5. Deploy first site
6. Deploy second site
7. Set up WordPress and log into each.
8. Make a change on the first site (change the "styles" of the default theme).

The change was NOT reflected on the second site. This issue was not reproduced.

So can you tell us more?

[dalepgrant]

Thanks for checking @MWDelaney 🙏 I've been meaning to come back with more info as I know I wrote this report super quick.

I didn't realise but I can actually replicate this in my local. I will try to get a repeatable demo up for you to check, but all I have to do to trigger this is add the change from #714 into two sites and it goes haywire.

I'll come back to add more, but here's some screenshots to show what I'm seeing and the steps I took:

• Start with two sites set up without changes from #714, login to both.
• Add changes to site 1 (in the screnshots, this is the right hand side), re-login as it signs you out
• Add changes to site 2 (in the screenshots, this is the left hand side), visit wp-admin and see site 1 details shown.

Before

After

[dalepgrant]

I've narrowed this down to usage with Redis, can reproduce consistently with a test setup.

Scratch that. In prepping the repo for someone to look at and reproduce, I've found the error of my ways. 🤦‍♂️

We were using Config::define('WP_CACHE_KEY_SALT', getenv('DB_NAME')); to avoid conflicts with dbs when using Redis. The getenv() turned out to be the issue. Change to env() and voila, no more issues. Should have read the issue notes more clearly, it does say about getenv() (and putenv()).

I'll leave the repo up, maybe it'll help someone else. Thanks for looking at this 🙏