Threaded comments

[roots]

Threaded comments

[retlehs]

what's not working?

http://snapplr.com/p7bd

roots doesn't do javascript comment functionality but threaded comments still work

[seraphangel]

Oh sorry, it's my mistake, instead of replying to the comment I actually created a new comment which appeared as not threaded. My bad.

[gavsiu]

Why remove the javascript comment functionality? The page now has to reload after clicking on a reply link.

[retlehs]

This issue is two years old and no longer accurate. It's in there now, see
https://github.com/retlehs/roots/blob/master/lib/scripts.php#L56

Sent from my iPhone

On Apr 13, 2013, at 11:50 AM, gavsiu [email protected] wrote:

Why remove the javascript comment functionality? The page now has to reload
after clicking on a reply link.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/59#issuecomment-16336468
.

[gavsiu]

What does this have to do with jQuery fallback? The problem I'm having is when I click on a reply comment link, it reloads the page.

I retested this by downloading the zip from github and uploading roots to my website. It's the same thing. comment-reply js loads, but doesn't really work.

There seems to be quite a bit of work done on the comments templates recently. Maybe that somehow broke this?

[retlehs]

Thought I linked the comment-reply line, I'm on my phone. Recently a commit
was added to add the comment ID that was missing in the comments template.
Are you using the latest?

Sent from my iPhone

On Apr 13, 2013, at 11:57 AM, gavsiu [email protected] wrote:

What does this have to do with jQuery fallback? The problem I'm having is
when I click on a reply comment link, it reloads the page.

I retested this by downloading the zip from github and uploading roots to
my website. It's the same thing. comment-reply js loads, but doesn't really
work.

There seems to be quite a bit of work done on the comments templates
recently. Maybe that somehow broke this?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/59#issuecomment-16336598
.

[sfradel]

The missing comment ID creates this problem. This is fixed in the latest version.

[gavsiu]

Where is the comment ID? I only see it added as a class on https://github.com/retlehs/roots/blob/master/lib/comments.php#L31

I downloaded the zip just now. I commented out activation.php, rewrites.php, and htaccess.php to test.

[gavsiu]

Forget what I mentioned. Whatever the problem was, it's fixed in my theme.