Comments (3)
For the is_*_param
case: bjoelle has a point, see for example:
is_alpha_param <- function(
x
) {
if (!is_param(x)) return(FALSE)
x$name == "alpha"
}
I do easily see that I can reduce those two lines to one, but I do not think it's worth it for three reasons:
- the functions this applies to are still trivially simple
- not all functions are as simple, for example:
is_kappa_1_param <- function(
x
) {
if (!is_param(x)) return(FALSE)
if (x$name != "kappa_1") return(FALSE)
if (!"lower" %in% names(x)) return(FALSE)
if (!"value" %in% names(x)) return(FALSE)
if (!"estimate" %in% names(x)) return(FALSE)
TRUE
}
- It reflects the current state of the package: not all parameters have a lower, upper, or estimate argument yet
I do predict in the future these is_*_param
functions will get the same shape. At the current state, I think it's not worth it to refactor the is_*_param
functions.
from beautier.
Likewise for parameter_to_xml_*
: it reflects the state of the package.
Note how this ties in with #45.
from beautier.
I feel that bjoelle is right, yet it should and can be done as suggested if and only if the package is in a finished state. Because the package is not yet complete, this Issue must be moved to the future and potentially re-opened then.
from beautier.
Related Issues (20)
- Add value, upper and lower HOT 1
- Add missing data doc HOT 2
- Broken link found (/join_next?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E&source=header-repo) HOT 1
- Broken link found (/join_next?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E&source=header-repo&source_repo=ropensci%2Fbeautier) HOT 1
- Broken link found (/join_next?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E&source=header-repo) HOT 1
- Broken link found (/join_next?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E&source=header-repo&source_repo=ropensci%2Fbeautier) HOT 1
- Clock rate added twice HOT 2
- Doubling of clockPrior ID HOT 1
- beautier writes and leaves behind in .cache files HOT 2
- Feature request: add offset HOT 14
- Feature request: allow multiple MRCA priors HOT 7
- Fix CRAN issues HOT 3
- Implementing options to run Birth Death Skyline Serial HOT 1
- Incompatibility between BEAST 2.7 and babette HOT 1
- Resulting xml cannot estimate clock rate in a uniform distribution prior HOT 10
- kappa in HKY site model must be a param
- Resulting xml cannot estimate clock rate in a lognormal distribution prior HOT 3
- Bug report: clock rate cannot be set to follow a normal distribution HOT 5
- Add `rate_scaler_factor` to have `scaleFactor` in XML HOT 1
- Fix https://github.com/ropensci/babette/issues/106
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beautier.