Giter Site home page Giter Site logo

Comments (3)

arne48 avatar arne48 commented on June 3, 2024 1

Cherry-picking is actually another good idea I just wasn't sure about 1.x version tree.
Thank you very much for clarifying this; I now cherry-picked #21 and #28.
During testing, I noticed the bug that was fixed with #37 and cherry-picked that commit as well.
Compared to version 2.0.2, this version now seems to be only short of #31, but this should be fine as here ros2/ros2cli#627, it is discussed that this would break on focal.
I also bloomed the new version already.
Thank you very much for your help @tfoote :)

I hope closing this issue would be therefore fine now.

from rqt_console.

arne48 avatar arne48 commented on June 3, 2024

I am currently trying to figure out the best approach to get an updated release 2.0.2 for foxy.
Because the foxy-devel branch was reverted to version 1.1.1 after it was branched off of 2.0.0
Currently, I think one way could be to reset the foxy-devel branch to 2.0.0 and then rebase or fast-forward to the humble branch, aka 2.0.2
But my gut feeling for using reset is pretty bad.
Another more practical way could be changing the devel_branch in the gbp repository for foxy to humble and get the 2.0.2 version that way.
Afterward, we could just wait out the time until next year when foxy enters its EOL.
I already tested the current humble branch in foxy, and it works, so for this release, this could be a non-intrusive solution.

Which one would you @tfoote prefer?

But maybe I also oversee the obvious in that case; I would also be very thankful for a hint :)

from rqt_console.

tfoote avatar tfoote commented on June 3, 2024

We don't need to push that far forward. It would be fine to just cut a 1.1.2 release with the patches staged on the foxy-devel branch already. The specific fix has been backported directly. The fixes are in f174bd9 and 9442cc8

Since the 2.0.0 number change was only in the source and not released into foxy, it being reverted isn't a problem.

It does look like the changes in the humble branch would be fine to release into foxy. But I'd suggest for now doing the simplest solution of just going to 1.1.2 on the foxy branch. It looks like the source branch should be updated to foxy-devel in the rosdistro and release repository from the previously unforked dashing-devel but otherwise it's just a patch release.

from rqt_console.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.