test_logging_output_format tests broken

[ros2]

test_logging_output_format tests broken

[clalancette]

This failure is a bit weird, since I don't see it in the CI nightlies or locally. That leads me to suspect that it may be cyclonedds-specific; I'm going to kick off a local build to see if I can reproduce it that way.

[rotu]

@clalancette I see these failures on the Linux nightly, even on the last stable build, and even with CycloneDDS disabled --- it does not report as a test failure. Do a search for "Task exception was never retrieved":

https://ci.ros2.org/view/nightly/job/nightly_linux_release/lastStableBuild/consoleText

[clalancette]

@clalancette I see these failures on the Linux nightly, even on the last stable build, and even with CycloneDDS disabled --- it does not report as a test failure. Do a search for "Task exception was never retrieved":

Oops, yeah, my eyes slipped right over it since it wasn't a failure. Investigating...

[clalancette]

All right. This turns out to be a bug in launch, though there is a way to workaround it in the test itself.

The bug basically comes down to the fact that this particular test doesn't have any tests that run concurrently with the processes under test. It only has a test that runs after shutdown. In that scenario, launch_testing seemingly fires up some kind of "dummy" unittest case, which completes immediately because it has no tests. The rest of launch_testing then gets confused because a process under its control fired up and quit, but it has no record of it. I'm going to file a bug against launch_testing for that.

In the meantime, we can workaround this particular failure by adding a test that runs in parallel with the processes, just waiting for them to complete. I'll open a PR for that presently as well.

[clalancette]

ros2/launch#380 is the new bug under launch.

#209 is a workaround for this until the launch bug gets fixed.

[rotu]

@clalancette thanks for demystifying this!