ImportError when importing two different packages generated with binder that share an overlap

[kliegeois]

ImportError when importing two different packages generated with binder that share an overlap

[kliegeois]

Currently, I implemented it as a per namespace option with one option to do it for all namespaces. Hopefully I can open the PR today.

[kliegeois]

This is a known pybind11 issue pybind/pybind11#439

[kliegeois]

This would probably require a modification of binder though.

[lyskov]

@kliegeois have you tried compiling and exporting using described approach? What i want to double check is that how Pybind11 reacts to attempts to register same type under different names.

re idea itself: assuming that proposed solution is works (see my above question), i am open to the idea but this seems a bit "messy". I imaging a few packages when each have its own std:: bindings... so user will ends up with multiple bindings for the same types. I wonder if cleaner solution is possible here, for instance perhaps it is possible to check if bindings for particular type_id was already registered? And if yes then skip bindings procedure. Have you investigate this approach?

[kliegeois]

@lyskov the described approach:

For A:

pybind11::class_<std::fpos<__mbstate_t>> cl(M("std"), "A_fpos___mbstate_t_t", "");

For B:

pybind11::class_<std::fpos<__mbstate_t>> cl(M("std"), "B_fpos___mbstate_t_t", "");

does not work.

But,

For A:

pybind11::class_<std::fpos<__mbstate_t>> cl(M("std"), "_fpos___mbstate_t_t", "", py::module_local());

For B:

pybind11::class_<std::fpos<__mbstate_t>> cl(M("std"), "_fpos___mbstate_t_t", "", py::module_local());

Does work.

It seems to even work when you parse an instance of a class from one package to the other providing that both of them define that class.

I have a PR ready to solve this issue with extra options. I just cannot create the PR right now.

[lyskov]

oh, i am glad to hear that passing py::module_local() solve this, - this is much cleaner solution, - great! - looking forward for PR thats add this!

[lyskov]

re how to solve this: - i wonder if it will make sense to provide options to trigger local bindings both per-class and per-namespace basis 🤔...

[kliegeois]

Closed by #251.