Comments (10)
Option 1 would be fantastic.
Option 2 is something for the loooong run.
However, having all accounts of an exchange consolidated into one (Option 1) will help a lot, because I am primarily interested in the overall performance of my accounts.
from rotki.
Tentatively putting in v1.9.0 milestone. May be easier than expected and may implement earlier. Or harder and take longer. Would need to see.
Naturally if any open source contributor would like to tackle this it would be really great.
from rotki.
Just to get some clarification @lordi @rakanalh @busera @grooveuser your requirement is:
1.Be able to add multiple exchange accounts and have all balances, history, trades, deposit/withdrawals etc. bundled. So whenever you get your trades you will still see all your (let's say kraken) trades under the Kraken logo. But in reality they will be from many different kraken accounts.
2. Be able to add multiple exchange accounts and have all balances, history, trades, deposit/withdrawals managed separately. So whenever you get your trades let's say you will see all your (let's say kraken) trades under the different Kraken entries. Kraken account-1, kraken account-2 etc.
I understand the feature request as bullet point (1). Bullet point (2) is considerably much much harder for us to implement. What were you guys thinking?
from rotki.
I am taking this up for v1.17.0 as discussed in the standup.
from rotki.
I also agree this should be done... at some point i created a different binance account to be able to "separate" funds... being able to import both accounts would be great.
from rotki.
I am also looking for multiple account support for one exchange. I have multiple sub-accounts at the Binance exchange.
from rotki.
+1 and option 1 suffices 👍
from rotki.
Thank you for tackling this, I've found that problematic too. I'll try to test. Best wishes !
from rotki.
Not fixed yet. A bit of frontend work by @kelsos is still needed. after #2780 got merged.
from rotki.
So @kelsos changes needed in the frontend:
- The string representation changes for 2 locations. for crypto.com -> cryptocom and for binance_us -> binance us
- Multiple api keys can now be added per exchange. And exchange credential entries can be edited. Not the actual credentials but the peripherals like exchange name, passphrase if existing, kraken account type if existing.
- kraken_account_type is removed from settings.
- To see the endpoint changes check the api docs in the PR: https://github.com/rotki/rotki/pull/2780/files
- TL;DR: Now an exchange is uniquely identified by location + name and you can also edit exchange credentials.
- e2e tests will also need fixing
from rotki.
Related Issues (20)
- Change how cost basis is displayed in the report for ACB
- Add information about the direction of events in PnL
- Eth staking execution rewards are doubled in 1.32.0 HOT 1
- Add functionality/checkbox for "Hide assets <1 USD" HOT 2
- Accounting rules for eth staking events
- Invalid ENS names cause Ethereum transaction decoding to halt. HOT 5
- Statistic: format currency
- Statistic: Hide Asset Amount and value over time graph when no asset is selected HOT 1
- Manual price is ignored if asset has special price calculation HOT 1
- Price calculation for curve pools is wrong in some cases
- Asset search, database globaldb already in use
- Allow for customization of CSV file delimiter HOT 5
- Add support for yearn v3
- Support Gearbox protocol
- Not possible to connect to Coinbase Exchange. API endpoint ".../buy" is deprecated. Use ".../transactions" instead. HOT 2
- Add mexc exchange support
- Allow customization of asset groups and collections
- Support EigenLayer Native restaking
- Premium DB syncing allow choice of automatic handling sync errors
- Coinbase api validation error: Unknown currency HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rotki.