Giter Site home page Giter Site logo

Comments (7)

rpgmaker avatar rpgmaker commented on July 27, 2024

I already understand how to generate IL code that access non public types
and members.

I just simply choose not to use dynamic methods and stick to dynamic
assembly since it allows me to avoid the cost of calling delegates which we
all know would be slower.

Plus generally I dont see the need for serializing non public except for
the case of anonymous type which makes sense. Because most people use it
for restful api.

If I do add it at some point, it will be surely slow. :)

from netjson.

tanglebones avatar tanglebones commented on July 27, 2024

If you generate the types to a single assembly we can mark our assemblies InternalsVisibleTo that assembly and avoid the dynamic methods. Currently the emitted code resides in multiple assemblies, each named after the serialization type it contains. Moving them all to a single assembly with a predictable name, like "NetJsonEmitted" would make the InternalsVisibleTo trick easier. This might require pre-declaring the types to be generated. (perhaps add a GenerateTypesTo(string assemblyName, type[] types) call?)

from netjson.

rpgmaker avatar rpgmaker commented on July 27, 2024

I guess such a method could work when it comes to generating a single
assembly for all types. But the issue is that there are problem with non
public classes because you cannot read or set values for them since they
are inaccessible. And your solution will only work if you convert all
private to internal.

I was thinking of generating mix code where setter and getter are dynamic
methods for non public type similar to what I did for messageshark.
On Apr 6, 2015 3:08 PM, "Cliff Hammerschmidt" [email protected]
wrote:

If you generate the types to a single assembly we can mark our assemblies
InternalsVisibleTo that assembly and avoid the dynamic methods. Currently
the emitted code resides in multiple assemblies, each named after the
serialization type it contains. Moving them all to a single assembly with a
predictable name, like "NetJsonEmitted" would make the InternalsVisibleTo
trick easier. This might require pre-declaring the types to be generated.
(perhaps add a GenerateTypesTo(string assemblyName, type[] types) call?)


Reply to this email directly or view it on GitHub
#10 (comment).

from netjson.

tanglebones avatar tanglebones commented on July 27, 2024

Not all private to internal; just those classes we want to serialize/deserialize. In my case those are special classes reversed specifically for representing the json data contracts and they should not be visible as part of the public api for the assembly (the assembly implements json protocols, how it does that is its business). It doesn't solve the private setter problem, but it does solve my use case.

from netjson.

rpgmaker avatar rpgmaker commented on July 27, 2024

Go ahead and create another issue in regards to generating a single
assembly for a collection of types.
On Apr 6, 2015 7:48 PM, "Cliff Hammerschmidt" [email protected]
wrote:

Not all private to internal; just those classes we want to
serialize/deserialize. In my case those are special classes reversed
specifically for representing the json data contracts and they should not
be visible as part of the public api for the assembly (the assembly
implements json protocols, how it does that is its business). It doesn't
solve the private setter problem, but it does solve my use case.


Reply to this email directly or view it on GitHub
#10 (comment).

from netjson.

tanglebones avatar tanglebones commented on July 27, 2024

Added as #50

from netjson.

rpgmaker avatar rpgmaker commented on July 27, 2024

Closing issue since it is been hanging for too long. Will create a new issue once ready to implement solution for it.

Thanks,

from netjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.