Comments (7)
I already understand how to generate IL code that access non public types
and members.
I just simply choose not to use dynamic methods and stick to dynamic
assembly since it allows me to avoid the cost of calling delegates which we
all know would be slower.
Plus generally I dont see the need for serializing non public except for
the case of anonymous type which makes sense. Because most people use it
for restful api.
If I do add it at some point, it will be surely slow. :)
from netjson.
If you generate the types to a single assembly we can mark our assemblies InternalsVisibleTo that assembly and avoid the dynamic methods. Currently the emitted code resides in multiple assemblies, each named after the serialization type it contains. Moving them all to a single assembly with a predictable name, like "NetJsonEmitted" would make the InternalsVisibleTo trick easier. This might require pre-declaring the types to be generated. (perhaps add a GenerateTypesTo(string assemblyName, type[] types) call?)
from netjson.
I guess such a method could work when it comes to generating a single
assembly for all types. But the issue is that there are problem with non
public classes because you cannot read or set values for them since they
are inaccessible. And your solution will only work if you convert all
private to internal.
I was thinking of generating mix code where setter and getter are dynamic
methods for non public type similar to what I did for messageshark.
On Apr 6, 2015 3:08 PM, "Cliff Hammerschmidt" [email protected]
wrote:
If you generate the types to a single assembly we can mark our assemblies
InternalsVisibleTo that assembly and avoid the dynamic methods. Currently
the emitted code resides in multiple assemblies, each named after the
serialization type it contains. Moving them all to a single assembly with a
predictable name, like "NetJsonEmitted" would make the InternalsVisibleTo
trick easier. This might require pre-declaring the types to be generated.
(perhaps add a GenerateTypesTo(string assemblyName, type[] types) call?)—
Reply to this email directly or view it on GitHub
#10 (comment).
from netjson.
Not all private to internal; just those classes we want to serialize/deserialize. In my case those are special classes reversed specifically for representing the json data contracts and they should not be visible as part of the public api for the assembly (the assembly implements json protocols, how it does that is its business). It doesn't solve the private setter problem, but it does solve my use case.
from netjson.
Go ahead and create another issue in regards to generating a single
assembly for a collection of types.
On Apr 6, 2015 7:48 PM, "Cliff Hammerschmidt" [email protected]
wrote:
Not all private to internal; just those classes we want to
serialize/deserialize. In my case those are special classes reversed
specifically for representing the json data contracts and they should not
be visible as part of the public api for the assembly (the assembly
implements json protocols, how it does that is its business). It doesn't
solve the private setter problem, but it does solve my use case.—
Reply to this email directly or view it on GitHub
#10 (comment).
from netjson.
Added as #50
from netjson.
Closing issue since it is been hanging for too long. Will create a new issue once ready to implement solution for it.
Thanks,
from netjson.
Related Issues (20)
- Urgent! Float deserialization fails on v 1.3.1 HOT 2
- Getting Exception when serializing HOT 26
- Invalid JSON causes full CPU usage (infinite loop) HOT 29
- Deserialization into simple char causes System.IndexOutOfRangeException HOT 3
- Could not load type 'TenantClass' HOT 9
- mysterious deserialization result for auto property initializer HOT 18
- The implementation of ToCamelCase can be optimized HOT 22
- NetJSONKnownType doesn't work HOT 20
- Serialize/Deserialize to/from Stream HOT 4
- Getting exception when Deserialize HOT 16
- Time for .Net 5 Release HOT 15
- Ignore object properties HOT 2
- Deserialization to a class that contains enum cause an error HOT 2
- Benchmark NetJSON with the JSON serializer comes with .NET 5? HOT 25
- Edge-Case failures to deserialize DateTime value HOT 9
- Invalid DateTime when deserializing from ISO-8601 HOT 12
- Encounter InvalidProgramException HOT 23
- NetJSON.NetJSONTypeMismatchException: 'Unexpected type was encountered in JSON' HOT 8
- When deserialize null result it throw "Input is not a valid JSON". HOT 3
- When the `value` is null the `SerializeObject` will throw NullReferenceException HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from netjson.